| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:47:31 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=434.624967,conversation_content-fragment;desc="conversation_content fragment";dur=1023.139164,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=321.725412,nginx;desc="NGINX";dur=1.372239,glb;desc="GLB";dur=139.243176
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=h9LUNwfBX6xmtWjgaqy3fYEPBa19lDBsn%2FvfoNtN0frxdOO1%2FkD8lFmoJzwExW6AtFCK2FWK0hUZzdfidEXw1ei9tABYjYeihUeQKPeWdo3QCUMwQ5OZkSFRO7rhxGWtKBmAj0l1DXavp3YAQUTBA0id2C7GTr%2BCYfFa3XT3ntQuTw2y33q7SZ1oQLgQ9x%2FD0TeibkR2SQ8m2dsXWpdbUEiQleZqXYfINGWdHPyQPHxmzbPW%2F%2BLdW%2F66CA3jHLCLpm97eCLvd8PxHCNOGbEZDQ%3D%3D--rLc4VaQFYNZ9H0gf--wXIJbl8xyrjIl%2Bagl3IUKQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.108384158.1760197650; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:47:30 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:47:30 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8CCE:2C8153:8266E8:AB77EC:68EA7C12
Author, Author Name block: fix PHP warning error when there is no context by t-hamano · Pull Request #69949 · WordPress/gutenberg · GitHub
t-hamano
added
[Type] Bug
An existing feature does not function as intended
[Block] Post Author
Affects the Post Author Block
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
[Block] Author Name
Affects the Author Name Block
labels
Apr 19, 2025
t-hamano
removed
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Apr 28, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Author, Author Name block: fix PHP warning error when there is no context #69949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Apr 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, the User REST API doesn't allow listing users if they have no posts written yet. As a follow-up, we may also need to add a check for the number of posts a user has written, in accordance with the REST API specification, in both blocks.
That condition has its problems and might change in the future. See: #69921
|
@Mamaduka Thanks for the review! I'd like to add @justlevine, who first reported this issue on Slack, to the props list: https://wordpress.slack.com/archives/C02QB2JS7/p1744930825415699 |
|
Of course! This would be their WP contribution email. |
t-hamano
added a commit
that referenced
this pull request
Apr 28, 2025
…text (#69949) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org>
|
A backport PR for the |
t-hamano
added a commit
that referenced
this pull request
Apr 28, 2025
…text (#69949) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org>
|
Removing the |
t-hamano
removed
the
Backport to WP Minor Release
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…text (WordPress#69949) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: justlevine <justlevine@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Author Name
Affects the Author Name Block
[Block] Post Author
Affects the Post Author Block
[Type] Bug
An existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Follow-up #67136
Closes #69948
Why?
Fixes PHP warning error when the Author and Author Name block have no context.
See #69948
How?
Checks for the existence of a context. If it doesn't, it continues with further processing. That is, if the block isn't relevant for a particular post type, it will be rendered.
However, the User REST API doesn't allow listing users if they have no posts written yet. As a follow-up, we may also need to add a check for the number of posts a user has written, in accordance with the REST API specification, in both blocks.
Testing Instructions
authorparam value to the actual user id for the newly added user)