| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 13 Oct 2025 03:02:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=349.908492,conversation_content-fragment;desc="conversation_content fragment";dur=1591.179644,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=324.635579,nginx;desc="NGINX";dur=0.936694,glb;desc="GLB";dur=138.517768
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=9TaJ2oRG17Ok5JDYYXJsVwsrhawD1KfP04yX1%2FaBddy1pfDBzHsClEy3ejsGFUfkeYF1cGfjR11AE%2Fpx83O8CZkCqikZBvmzXP7vujYQqzY%2BOXeI1qDCk3%2FgwWYaQY293zl4vCpscrACbzVZVLhxZ4p3xPEKoYCMH5K6uw5TjzVY77o9N92F6aTDP4aIKykUZ28xh3VWLq0CC3Irkwi5b63O8VO91OJi3EjSy4rrUkPAMLwpeyMkZb%2Bk7xNIPAw77UJQM%2FNBQ3vkT32itpknww%3D%3D--OImIRZmWTsbpxyKU--iF3MmYO%2BNRgSioyWa0h9iA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1062957630.1760324553; Path=/; Domain=github.com; Expires=Tue, 13 Oct 2026 03:02:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 13 Oct 2026 03:02:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8B24:188225:513B75:6E4EBD:68EC6BC9
Snackbar: Add support to open links in new tab by yogeshbhutkar · Pull Request #69905 · WordPress/gutenberg · GitHub
yogeshbhutkar
changed the title
Snackbar: Add support to open
Snackbar: Add support to open links in new tab
Apr 15, 2025
Mamaduka
added
[Type] Enhancement
A suggestion for improvement.
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
labels
Apr 15, 2025
yogeshbhutkar
force-pushed
the
enhance-59139/snackbar-component
branch
from
April 21, 2025 05:30
yogeshbhutkar
force-pushed
the
enhance-59139/snackbar-component
branch
2 times, most recently
from
April 25, 2025 11:08
yogeshbhutkar
force-pushed
the
enhance-59139/snackbar-component
branch
from
May 5, 2025 04:03
yogeshbhutkar
force-pushed
the
enhance-59139/snackbar-component
branch
from
May 8, 2025 10:41
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Snackbar: Add support to open links in new tab #69905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mamaduka
merged 7 commits into
WordPress:trunk
from
yogeshbhutkar:enhance-59139/snackbar-component
May 9, 2025
Merged
Snackbar: Add support to open links in new tab #69905
Mamaduka
merged 7 commits into
WordPress:trunk
from
yogeshbhutkar:enhance-59139/snackbar-component
May 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshbhutkar
changed the title
snackbar links in new tab
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Enhancement
yogeshbhutkar
force-pushed
the
enhance-59139/snackbar-component
branch
from
aa0c974 to
22afc75
Compare
|
The failing test appears unrelated to the changes introduced in this PR and passes locally. I believe it should pass upon re-running. |
yogeshbhutkar
force-pushed
the
enhance-59139/snackbar-component
branch
2 times, most recently
from
8244804 to
6897766
Compare
yogeshbhutkar
force-pushed
the
enhance-59139/snackbar-component
branch
from
41579bc to
69b10da
Compare
|
Hi @Mamaduka, if you have some time, I'd really appreciate it if you could review this PR. Thanks in advance! |
Mamaduka
reviewed
May 7, 2025
yogeshbhutkar
force-pushed
the
enhance-59139/snackbar-component
branch
from
69b10da to
1f6bd33
Compare
Mamaduka
approved these changes
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @yogeshbhutkar! The changes look good to me âś…
It would be nice to get a sanity check from @WordPress/gutenberg-components team.
ciampo
reviewed
May 8, 2025
ciampo
reviewed
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a glance, code changes LGTM.
Not allowing onClick ehrn url is defined seems a bit arbitrary, but I guess not in the scope of this PR.
|
Thanks for the feedback, @ciampo! Let's merge this. We can leave |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] UI Components
Impacts or related to the UI component system
[Package] Components
/packages/components
[Type] Enhancement
A suggestion for improvement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #59139
This PR enhances the Snackbar component by adding support for opening links in a new tab. Accordingly, the View Post, View Site, and View Preview links have been updated to open in a new tab by default.
Why?
Opening these links (View Post, View Site, and View Preview) in a new tab improves the user experience by preserving the current editing context.
How?
Consumers can now pass an
openInNewTabboolean property to an action item to open that specific item in a new browser tab.Testing Instructions
Post.View Postin the snackbar notification.Testing Instructions for Keyboard
Same.
Screencast
PR.mov