You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR disables "Edit as HTML" for invalid blocks in favor of "Attempt recovery" as the primary action.
Why?
The "Edit as HTML" toggle doesn't work on trunk.
I know that the issue suggests leaving the option available. Still, after the initial commit, I realized that it would delay invalid content feedback and leave blocks in HTML editing mode.
Testing Instructions
Create a post.
Add a paragraph block with some text.
Edit block as HTML and remove the trailing </p> tag.
Move focus to the post title.
Confirm that the invalid content warning is displayed.
Open block options.
Confirm that the "Edit as HTML" menu item isn't displayed.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
Unlinked Accounts
The following contributors have not linked their GitHub and WordPress.org accounts: @aduth, @enriquesanchez.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #7743.
PR disables "Edit as HTML" for invalid blocks in favor of "Attempt recovery" as the primary action.
Why?
The "Edit as HTML" toggle doesn't work on
trunk
.I know that the issue suggests leaving the option available. Still, after the initial commit, I realized that it would delay invalid content feedback and leave blocks in HTML editing mode.
Testing Instructions
</p>
tag.Testing Instructions for Keyboard
Same.
Screenshots or screencast