You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the error while using the __experimentalLinkControl and accessing its static properties like DEFAULT_LINK_SETTINGS.
Why?
The __experimentalLinkControl was stabilized as LinkControl in PR #56384. Following this change, using __experimentalLinkControl in blocks leads to errors because it lacks the necessary static properties. This can create issues in custom blocks that still utilize __experimentalLinkControl . This PR addresses the issue by adding those static properties to DeprecatedExperimentalLinkControl.
How?
Testing Instructions
Add any custom block that uses __experimentalLinkControl and access DEFAULT_LINK_SETTINGS
or update the core button block
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Although these sub-components are not exported, they still exist within DeprecatedExperimentalLinkControl(__experimentalLinkControl). However, the values ViewerFill and DEFAULT_LINK_SETTINGS are not present on this deprecated component, which is causing an error—not just a deprecation warning while using those values.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #69861
Fixes the error while using the
__experimentalLinkControl
and accessing its static properties likeDEFAULT_LINK_SETTINGS
.Why?
The
__experimentalLinkControl
was stabilized asLinkControl
in PR #56384. Following this change, using__experimentalLinkControl
in blocks leads to errors because it lacks the necessary static properties. This can create issues in custom blocks that still utilize__experimentalLinkControl
. This PR addresses the issue by adding those static properties toDeprecatedExperimentalLinkControl
.How?
Testing Instructions
__experimentalLinkControl
and accessDEFAULT_LINK_SETTINGS
or update the core button block
gutenberg/packages/block-library/src/button/edit.js
Line 40 in b17d1ca
to previously used
__experimentalLinkControl
Testing Instructions for Keyboard
Same
Screenshots or screencast