| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 09:46:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=379.667795,conversation_content-fragment;desc="conversation_content fragment";dur=1012.104021,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=347.127888,nginx;desc="NGINX";dur=1.395245,glb;desc="GLB";dur=138.896203
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=H%2BfX38P7gF97syjIm083bvdZ91E4lS3hl9KMTQVjgjGXI6XLHpoQthjSXkK0DlAkde5QErKjl3jrpLUzt2Rtz3GQbYGp7fhPb5jocbEZGVbF98YDqInN5JsNO2zsRhj88M3GF8WX0CfBm5WEQCGjdoUFeQRw61udERp0cZ3gZAa9NJmGQk%2FiZl5k4BZGqXHwlTwnDtCQ8Bk9y07PWwT5e5NWcCQPo4Q0ETN0kemeOPyxNiY9rqObROObOEUdEd5PxBcX2zrv4mjsg5a6%2FzrshA%3D%3D--tUApsYoqDOJqGoHC--Tyr6HRVkClE0Wpgi8CvKlg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1904990153.1760175973; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:46:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:46:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D8E0:3CB96D:53CF6B:7158AC:68EA2765
Navigation block: fix submenu Escape key behavior by stokesman · Pull Request #69837 · WordPress/gutenberg · GitHub
stokesman
added
[Type] Bug
An existing feature does not function as intended
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Block] Navigation
Affects the Navigation Block
labels
Apr 6, 2025
stokesman
changed the title
Navigation block: Fix focus loss when pressing Escape from nested menu item
Navigation block: fix submenu Escape key behavior
Apr 6, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Navigation block: fix submenu Escape key behavior #69837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stokesman
merged 4 commits into
trunk
from
fix/navigation-nested-menu-esc-key-focus-loss
Apr 7, 2025
Merged
Navigation block: fix submenu Escape key behavior #69837
stokesman
merged 4 commits into
trunk
from
fix/navigation-nested-menu-esc-key-focus-loss
Apr 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 07142c2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/14287716831
|
stokesman
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! This PR works very well for me.
Testing keyboard accessibility with screen reader:
1baacce029df89a60ed8ed6c5ea05355.mp4
|
Thanks for the review 🙇. I was glad to see your testing included third-level menus and with “Open on click” disabled. |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* Add coverage in e2e tests * Fix focus loss when pressing Escape from nested menu * Update e2e test for closing one menu level * Have Escape key close a single menu level at a time Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Type] Bug
An existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #69834
When using the Escape key to close menus, this makes it only close one menu level at a time and focus the parent menu item.
Why?
When using the Escape key to close menus:
How?
previousFocusto the context (Interactivity API) of submenus. This makes each level have it’s own reference. Without this onepreviousFocusreference is shared by all levels and when set by a nested menu it overwrites the previous value causing it to be lost.stopPropagationcall to thekeydownhandler (when Escape key was pressed).Testing Instructions
Manually
Use the following HTML to create a Navigation with nested submenus:
HTML example
E2E
Screenshots or screencast