| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:48:15 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=498.59636,conversation_content-fragment;desc="conversation_content fragment";dur=957.101628,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=434.997292,nginx;desc="NGINX";dur=1.049453,glb;desc="GLB";dur=141.81234
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=3k%2B6%2Frrhv2qNokOVop4PeyNBZGtgb4PGLpsfByoxg4HYHNlKwOgz0Ta2MeiialyMFU7aSnMxApw2KyyAiLlekqarSZXW5JyGed1RNPztAXYq6ZJ4CInNakASQ0QkPzSuoT6NKQ8rrmcNL6cRVuJCojThbroHBKyHvOZihPAaxDgpg2kMP0JLr3rvY7WQZAiIVikst%2FEMBgfm82Dxb3OVfFsPUzBDcBwr7DX2v9UC4bu8JvSdLmrCm%2FexBgI5HbYWX%2Fn33O8ZT1Yqs6kOQBQV0Q%3D%3D--13Pw%2FduovJPxCemH--DvYmX2zofSHE8onfE5SrEw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.412480639.1760197694; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:48:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:48:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8D96:283FFC:430F11:53CF4A:68EA7C3E
Block Tools: Prevent showing block toolbar when block interface is hidden by yogeshbhutkar · Pull Request #69795 · WordPress/gutenberg · GitHub
stokesman
added
[Type] Bug
An existing feature does not function as intended
[Package] Block editor
/packages/block-editor
labels
Apr 2, 2025
yogeshbhutkar
force-pushed
the
fix-68711/block-tools
branch
from
April 3, 2025 04:27
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Tools: Prevent showing block toolbar when block interface is hidden #69795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
stokesman
added
[Type] Bug
stokesman
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! As a nitpick, ! isBlockInterfaceHidden() could be first in the list of conditions so when it evaluates to false it short-circuits the rest of them.
I agree with restoring this functionality because it does seem to have been unintentionally removed. That said, after testing, I do find it can feel a little distracting or mysterious in some cases. I guess mainly when there are no padding values to visualize but the block toolbar hides anyway. This and a few other details are covered in #45503 but I’m not suggesting we pursue any of that in this PR.
yogeshbhutkar
force-pushed
the
fix-68711/block-tools
branch
from
0ac6ba2 to
f258d24
Compare
|
Thanks for the review, @stokesman! I've implemented the suggested changes. As a follow-up to this PR, I'd like to work on the enhancements outlined in #45503. |
|
Thanks for working on this, @yogeshbhutkar! |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…dden (WordPress#69795) Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Block editor
/packages/block-editor
[Type] Bug
An existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #68711
This PR fixes a regression, likely introduced in #56914, that restores the visualizer's behavior of hiding the
Block Toolbarwhen theBlock Interfaceis hidden.Why?
An additional
isBlockInterfaceHidden()check seems to have been omitted here:gutenberg/packages/block-editor/src/components/block-tools/use-show-block-tools.js
Line 48 in 4ac0ade
How?
A check for
! isBlockInterfaceHidden()was added while determining_showBlockToolbarPopover.Additional Context
If we choose not to fix this regression, we should at least clean up the following unused code:
hideBlockInterfaceandshowBlockInterface, but this serves no purpose sinceisBlockInterfaceHidden()is currently unused.gutenberg/packages/block-editor/src/hooks/dimensions.js
Lines 34 to 35 in 4ac0ade
Testing Instructions
Block Toolbarhides when changing margins.Testing Instructions for Keyboard
Same.
Screencast