| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 09:45:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=476.236956,conversation_content-fragment;desc="conversation_content fragment";dur=1007.873903,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=343.414102,nginx;desc="NGINX";dur=1.019834,glb;desc="GLB";dur=146.709729
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=KvyDtmlyC%2BO6IsZlIKR9jZt0OxJfEWEgf9n43YHYrAwogDO%2FB%2BSb1EQBBDucnKqLGVyBMVY15qAZJxZSm1jVES9mEpBGIPE0rIY0UYMGO7y6uhk5NaYLMewzZWgcOpHfAN6ru1GclIV1eVi1LoEjEqKbUT8QHldQOuZRZk48Q38oPRPgszaekBrl%2B%2FMGqDxhlX2u5KhRl1mcKsjm%2F19BTX6OW3YVZ%2B7Ano98CCQA8Ckf3POo%2BdaUd5NoFOWM5EoFKnmNxmyuMT8xjSwEATvnKA%3D%3D--WKlBteJU0DH1w46L--5DhoRbFaMat%2BERGCt08t4Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1043091893.1760175954; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:45:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:45:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EBD6:12893F:53F4B3:717E1A:68EA2752
Scripts: Fix blocks manifest generation when directory name has space by t-hamano · Pull Request #69766 · WordPress/gutenberg · GitHub
t-hamano
added
[Type] Bug
An existing feature does not function as intended
[Tool] WP Scripts
/packages/scripts
labels
Mar 31, 2025
t-hamano
requested review from
ajitbohra,
nerrad,
ntwb and
ryanwelcher
as code owners
March 31, 2025 08:59
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Scripts: Fix blocks manifest generation when directory name has space #69766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
t-hamano
added
[Type] Bug
t-hamano
requested review from
ajitbohra,
nerrad,
ntwb and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hey @t-hamano, Screencast:Screen.Recording.2025-03-31.at.5.30.42.PM.mov |
gziolo
approved these changes
Mar 31, 2025
gziolo
added a commit
that referenced
this pull request
Apr 1, 2025
…#69766) * Scripts: Fix blocks manifest generation when directory name has space * Add changelog Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: srikat <srikat@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…WordPress#69766) * Scripts: Fix blocks manifest generation when directory name has space * Add changelog Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: srikat <srikat@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Fixes #69760
Follow-up #69578
Why?
If the scripts command has the
--blocks-manifestflag, thebuild-blocks-manifestcommand is executed internally. However, if the scripts is executed inside the directory with spaces, the following incorrect command is generated:Because there is no quote, the following invalid command will actually be executed:
Testing Instructions
Local Sites)npx @wordpress/create-block test-blocktest-blocknpm run startornpm run buildLocal Sites/test-block/build/directory doesn't haveblocks-manifest.phpfileLocal Sites/test-block/node-modules/@wordpress/scripts/config/webpack.config.jsfile and add changes that are the same as this PRnpm run startornpm run buildagainLocal Sites/test-block/build/directory hasblocks-manifest.phpfile