| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 12 Oct 2025 10:14:43 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=481.637124,conversation_content-fragment;desc="conversation_content fragment";dur=1124.002848,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=437.000849,nginx;desc="NGINX";dur=1.360578,glb;desc="GLB";dur=137.48756
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=VXfS9cy%2BZV3iqECW5m45WKyp1sirSTZUiXqiP1G5LJudcsx55HQRmjSVtY9TCXJoYVOi%2F6aE0Ca4axzqHSiRZmLBJyAT6XSOLQcrQig552I9rmiZgRqESb52aPZUuv8qsEqUUZlKh4pHg5%2B0jbRvLFrQAy97lXaaa%2FswzupuOgxKFAsX0ULVg73w1JOICPSo7Cv51DmvUg5vSAyIYJ87m4qvAvf7Jy1Zw8a7%2BXTGrhH1h9QiXbGZOBkzmE3B8DHq7jEcgpnPzGksWocjpLw5mw%3D%3D--mSRYNENSx4zAGp7U--RGLvChknt48zmqwDw9PrRg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.152673478.1760264082; Path=/; Domain=github.com; Expires=Mon, 12 Oct 2026 10:14:42 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 12 Oct 2026 10:14:42 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DF16:364294:E566C6:13247A0:68EB7F92
Fix: Space visualizer showing previous value by karthikeya-io · Pull Request #69747 · WordPress/gutenberg · GitHub
github-actions
bot
added
the
First-time Contributor
Pull request opened by a first-time contributor to Gutenberg repository
label
Mar 28, 2025
t-hamano
added
[Type] Bug
An existing feature does not function as intended
[Package] Block editor
/packages/block-editor
[Feature] Layout
Layout block support, its UI controls, and style output.
labels
Mar 31, 2025
karthikeya-io
force-pushed
the
fix/spacing-visualizer
branch
from
April 1, 2025 07:09
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix: Space visualizer showing previous value #69747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stokesman
merged 2 commits into
WordPress:trunk
from
karthikeya-io:fix/spacing-visualizer
Apr 1, 2025
Merged
Fix: Space visualizer showing previous value #69747
stokesman
merged 2 commits into
WordPress:trunk
from
karthikeya-io:fix/spacing-visualizer
Apr 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthikeya-io! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Bug
stokesman
reviewed
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for working on it. I’ve experimented with some alternatives and it does seem like leveraging a MutationObserver is the best bet.
I’ve tested this and didn’t find any problems. I think it might not be necessary to observe the class attribute and just the style may suffice but I don’t think it’s likely to be critical for performance and may be helpful in some less common cases.
I’d be okay with this landing as is but I have a few suggestions.
karthikeya-io
force-pushed
the
fix/spacing-visualizer
branch
from
9089c02 to
a3b76b8
Compare
stokesman
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested again and this works great. Thanks!
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* Fix: Space visualizer showing previous value * Refactor: replace useLayoutEffect with useEffect and remove unnecessary value from deps Co-authored-by: karthikeya-io <karthikeya01@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Layout
Layout block support, its UI controls, and style output.
First-time Contributor
Pull request opened by a first-time contributor to Gutenberg repository
[Package] Block editor
/packages/block-editor
[Type] Bug
An existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Part of #63191
Why?
Fixes the issue that Margin and Padding visualizer shows the previous value. This issue doesn't occur in Safari but occurs in Chromium based browsers.
Related PR #59227
How?
Use
MutationObserverto observe the changes in block.Testing Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast
space-visualizer-before.mov
space-visualizer-after.mov