| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 21:23:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=386.681747,conversation_content-fragment;desc="conversation_content fragment";dur=1484.141332,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=335.223675,nginx;desc="NGINX";dur=1.188628,glb;desc="GLB";dur=147.093559
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=8WLHr4njmymUTcBv1w%2BWbvRfS584JRJD6Fh115v3N%2BLa0AlF39f1g%2FNk%2FHHFssVf2fsQzidC20F6NgsILzgnoMjMzxSDV5rdOlyFD%2FjereUmwThSaq%2FNuFhnBrDGJJF%2BxgIN8BMqec3B9ZQgy2y1%2BRDvjI4%2BLB%2FzpFehuxvM1FZGjr0PHRn76j4D9sG%2Bw9OtB6GtU5HFW4jO%2B9URxFV6xVRyelLXDAjzrCx0dnKHxdMPqeFsI6%2FejeqUFKNlYlBBF6Nhh2nO%2Fs4GyNQmwT7Cmw%3D%3D--DQU005kDXrgZjkUY--LntFwv2WsvrE%2FYiLhsDU6A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.158915541.1760131391; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 21:23:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 21:23:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CADE:547BC:EDA1B:14737C:68E9793F
Enhance Featured Image Block: Don't include interactive elements within a element by Mayank-Tripathi32 · Pull Request #69730 · WordPress/gutenberg · GitHub
Mamaduka
added
[Type] Bug
An existing feature does not function as intended
[Block] Post Featured Image
Affects the Post Featured Image Block
labels
Mar 28, 2025
Mayank-Tripathi32
requested review from
ajitbohra and
fabiankaegy
as code owners
March 31, 2025 14:44
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Enhance Featured Image Block: Don't include interactive elements within a element #69730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 6 commits into
WordPress:trunk
from
Mayank-Tripathi32:try/enhance-69728-feature-image-block-v2
Apr 7, 2025
Merged
Enhance Featured Image Block: Don't include interactive elements within a element #69730
t-hamano
merged 6 commits into
WordPress:trunk
from
Mayank-Tripathi32:try/enhance-69728-feature-image-block-v2
Apr 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added checks for link to be shown only if featured image is set.
Mamaduka
added
[Type] Bug
|
Failing tests seems irrelevant to PR. |
Mayank-Tripathi32
requested review from
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@t-hamano Ready for review, failing tests seems irrelevant. |
t-hamano
reviewed
Apr 3, 2025
|
@Mayank-Tripathi32 It would be good to rebase this PR as a bug regarding the Resolution panel has been fixed. See #69805 |
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
@t-hamano Ready ^^ |
t-hamano
approved these changes
Apr 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! I left just one last suggestion but it's working as expected.
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ment (WordPress#69730) * Feat: removed the code from WordPress#69716 and fixed html structure, added checks for link to be shown only if featured image is set. * Fix: Update conditions for displaying link options in Post Featured Image edit panel * Refactor: Add conditional rendering to inspector controls * feat: add templates for single page templates Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * feat: add sizeSlug prop to reset handler --------- Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Post Featured Image
Affects the Post Featured Image Block
[Type] Bug
An existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Attempts fix for #69728
What?
This PR updates the behavior of the Featured Image block inspector to conditionally display link-related controls based on whether the block is inside a Query Loop or not.
Why?
How?
ScreenCast
https://q7utzrengv.ufs.sh/f/Wgl9eBAmTj29CAEDuMerV9jUpFsYux6DJmaP53zkqdRfyBQC