| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 21:24:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=397.013875,conversation_content-fragment;desc="conversation_content fragment";dur=1000.524361,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=360.025023,nginx;desc="NGINX";dur=1.343629,glb;desc="GLB";dur=137.752731
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=QDNtSQGYxl7uTVh8NqemdzUmJn4AxZUF6UOrbxhnuG%2BO%2FAhPVfFqCfJs48tqAMo2b52%2FphVLrM75AOkPKosAMk0%2BvD2D6TrgaTJqpP%2BMPUiAYbtXZsQs6ThO3NaNojjtngD4JYxhKrRF56yt9AK%2Br4NWgEU8rh8Z8VxxNH4%2F33skiB%2BvOWH7sR0OY7qKdKR%2FVR7oLqLmNw3sBqKlCyOlXFjBAtlczgi7GG2b9BRiifkDb39s7mJ8UXHEjE3SSyUn36Oib3uoOKpw51eSR0M%2B3A%3D%3D--7nu%2B4cjHN%2FsdFgiJ--lY7g8jd9Mt%2B3sJHwQkXMCQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.189215838.1760131439; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 21:23:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 21:23:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A5E6:9DC1D:EDFBD:1481B0:68E9796F
Navigation Link, Navigation Submenu: Remove the title attribute controls by Infinite-Null · Pull Request #69689 · WordPress/gutenberg · GitHub
Mamaduka
changed the title
Remove Title attribute controls
Navigation Link/Submenu: Remove the title attribute controls
Mar 25, 2025
Mamaduka
added
[Block] Navigation Link
Affects the Navigation Link Block
[Block] Submenu
Affects the Submenu Block - for submenus in navigation
[Type] Enhancement
A suggestion for improvement.
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
labels
Mar 25, 2025
Infinite-Null
requested review from
ajitbohra,
artemiomorales,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
March 27, 2025 06:26
Infinite-Null
changed the title
Navigation Link/Submenu: Remove the title attribute controls
Remove the title attribute controls
Mar 27, 2025
t-hamano
changed the title
Remove the title attribute controls
Navigation Link, Navigation Submenu: Remove the title attribute controls
Mar 31, 2025
t-hamano
added
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Apr 2, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Navigation Link, Navigation Submenu: Remove the title attribute controls #69689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 7 commits into
WordPress:trunk
from
Infinite-Null:remove/title-attribute
Apr 2, 2025
Merged
Navigation Link, Navigation Submenu: Remove the title attribute controls #69689
t-hamano
merged 7 commits into
WordPress:trunk
from
Infinite-Null:remove/title-attribute
Apr 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
changed the title
Mamaduka
added
[Block] Navigation Link
Infinite-Null
requested review from
ajitbohra,
artemiomorales,
fabiankaegy,
juanmaguitar and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Infinite-Null
changed the title
|
The failing tests don’t seem to be related to the changes in this PR. |
t-hamano
reviewed
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I think it would be good to focus only on two blocks, core/navigation-link and core/navigation-submenu in this PR.
If we plan to remove the title attribute from the Image block, we need to address the following tasks:
- If we update the save function, we will need to add a block deprecation.
- The
titleattribute is allowed to be used as Block Binding API (See this core code). This means that we may need to prepare a patch that removes thetitleattribute from the supported attributes to the core along with this PR.
I think It's too big to tackle all the tasks in one PR.
|
Hi @t-hamano, |
t-hamano
changed the title
t-hamano
reviewed
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to completely remove code related to the title attribute. For example:
gutenberg/packages/block-library/src/navigation-link/index.php
Lines 252 to 254 in d8545b2
| if ( isset( $attributes['title'] ) ) { | |
| $html .= ' title="' . esc_attr( $attributes['title'] ) . '"'; | |
| } |
| title, |
It's a good idea to go through the code in both blocks and look for anything that needs to be removed.
|
Hi @t-hamano, Thank You! |
t-hamano
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think all code related to the title attribute has been removed.
Since I think this change is very important for site builders, I'm adding a Needs dev note label to announce it in the next major release.
t-hamano
added
the
Needs Dev Note
Infinite-Null
added a commit
to Infinite-Null/gutenberg
that referenced
this pull request
May 28, 2025
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ols (WordPress#69689) * Remove Title attribute controls * Remove Title controls from Image component * Remove 'title' attribute from navigation link and submenu blocks * Remove title attribute checks from custom sources tests * Revert image changes * Remove `title` attribute from navigation link and submenu blocks Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> Co-authored-by: joedolson <joedolson@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…ping attribute support (WordPress#70234) * Revert the changes from PR WordPress#69689 * Remove title attribute from Controls in Navigation Link and Submenu blocks Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation Link
Affects the Navigation Link Block
[Block] Submenu
Affects the Submenu Block - for submenus in navigation
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Needs Dev Note
Requires a developer note for a major WordPress release cycle
[Type] Enhancement
A suggestion for improvement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Closes: #69663
What?
Removes the Title attribute UI option from Navigation Submenu block and Custom Link button to align with accessibility best practices.
Testing Instructions
Screenshots or screencast