You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that the inline image width persists correctly when updated via the width popover. Previously, removing the width caused the style attribute to be lost, preventing future updates from applying correctly.
Why?
When the width was removed and applied, the style attribute was cleared. Subsequent updates to width did not restore the style, leading to a persistent issue where the width couldn't be reapplied.
How?
Ensured style is correctly updated in onSubmit.
Used the previous style value when width is empty instead of removing the attribute.
Verified onChange is triggered properly with the new attributes.
Testing Instructions
Open a post or page in the editor.
Insert an inline image.
Open the width popover, remove the width, and click "Apply."
Refresh the page and verify the image no longer has a width.
Reopen the popover, enter a new width, and click "Apply."
Confirm that the width persists and updates correctly.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Mamaduka
changed the title
Fix: Ensure inline image width updates persist by correctly handling the style attribute
Format Library: Ensure inline image with updates persist after removing the 'width'
Mar 24, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #69678
This PR ensures that the inline image width persists correctly when updated via the width popover. Previously, removing the width caused the style attribute to be lost, preventing future updates from applying correctly.
Why?
When the width was removed and applied, the style attribute was cleared. Subsequent updates to width did not restore the style, leading to a persistent issue where the width couldn't be reapplied.
How?
Testing Instructions
Screenshots or screencast
inline-image-style-update-issue.mp4