| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:46:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=441.148547,conversation_content-fragment;desc="conversation_content fragment";dur=576.946225,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=330.698996,nginx;desc="NGINX";dur=0.992134,glb;desc="GLB";dur=141.141017
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=NrH5DkYPleNkf1ulwW9Wl5%2BBE9u2JZUxMxQrEIIZroFTtWyHjEAmL1sh5oTczjzeKcR5qetv%2FBGKoPARMG2O6zVPg6djUPTyWVvjGpDcPKhowQCR7nSZuujB55UZn3ac%2F5Ie6c6%2FUq56N2FA5FtOa94cF6mpiKP0IqIzTftB3mwIQLZvEOv%2Fp5IGxXvhkRPeJR2gUDiVei0jB%2BOg1SbYiKkyzqxf14B%2F8%2FjQqKeMbRa%2BTpgx2nIbZJNHeiK1crQkCqBJrE0vkrwEBsPN%2BttU1g%3D%3D--ysib9OaZqEdTJ88c--Xc8ijz7soMlwb9702dtPvA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1405968199.1760197584; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:46:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:46:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C2CE:547BC:8238D6:AB3D47:68EA7BD0
FontLibraryModal: Remove temporary margin-bottom override by SainathPoojary · Pull Request #69674 · WordPress/gutenberg · GitHub
t-hamano
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Feature] Font Library
labels
Mar 24, 2025
t-hamano
added
the
props-bot
Manually triggers Props Bot to ensure the list of props is up to date.
label
Mar 24, 2025
github-actions
bot
removed
the
props-bot
Manually triggers Props Bot to ensure the list of props is up to date.
label
Mar 24, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
FontLibraryModal: Remove temporary margin-bottom override #69674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t-hamano
merged 1 commit into
WordPress:trunk
from
SainathPoojary:remove/font-library-modal-margin-override
Mar 24, 2025
Merged
FontLibraryModal: Remove temporary margin-bottom override #69674
t-hamano
merged 1 commit into
WordPress:trunk
from
SainathPoojary:remove/font-library-modal-margin-override
Mar 24, 2025
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Code Quality
t-hamano
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
t-hamano
added
the
props-bot
github-actions
bot
removed
the
props-bot
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…69674) Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
related to: #38730
related comment: #64283 (comment)
Removes the temporary CSS rule that set
margin-bottomto0for.components-base-control__fieldwithin the.font-library-modal__tabpanel-layout.Why?
This PR cleans up the codebase by removing the CSS rule that was added as a temporary fix. The issue #38730 has been resolved, and all instances of
BaseControlnow use the__nextHasNoMarginBottomproperty.How?
The CSS rule:
has been removed from the codebase.
Testing Instructions
margin-bottomstyling for.components-base-control__fieldelements within.font-library-modal__tabpanel-layoutis correct and consistent with other components.Screenshots or screencast
2025-03-24.15-53-02.mp4