| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:46:47 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=446.250995,conversation_content-fragment;desc="conversation_content fragment";dur=1033.301172,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=397.068461,nginx;desc="NGINX";dur=1.656579,glb;desc="GLB";dur=141.781697
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=j8a0ofh6yhZXn4Zh4VI2Z9x6esvn1%2FdiwqqtXLhrLCSh1FR0LwJP%2FXCRZUF8INWPYJjMJXQMcvFiOAUe0npkZjKYa3%2FmjpFGSnrfhlULJbGvibiax6iMkp52mkMA3Eah8pzfGNjVoydqPDZO0jvEV2HGaVIg3Whl3lQdy7GPkF7HVdwgFiSFYq1%2FdVvaTonpYQYLc%2BqXuQtwi1ndRkK5nZclTMXbce6LNXYeUbYigOdzxeNyYAqcO1wAb0d5H2K7kuPWKb5mHM3e9ZFltj4FoQ%3D%3D--9aBZ9nXUgFwdYC37--%2BOrLfnVbxsRJ6%2BIX0fBblA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1296579533.1760197606; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:46:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:46:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C186:283FFC:42E291:5396F2:68EA7BE6
PostCommentsForm: Fix submit button width regression by im3dabasia · Pull Request #69651 · WordPress/gutenberg · GitHub
im3dabasia
force-pushed
the
fix/post-comment-form-button-regression
branch
from
March 21, 2025 11:47
t-hamano
added
[Type] Regression
Related to a regression in the latest release
Backport to WP 6.8 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
[Block] Comments Form
Affects the Comments Form Block
labels
Mar 21, 2025
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.8 Editor Tasks
Mar 21, 2025
t-hamano
moved this from 🔎 Needs Review
to 🏗️ In Progress
in WordPress 6.8 Editor Tasks
Mar 21, 2025
t-hamano
moved this from 🏗️ In Progress
to 🔎 Needs Review
in WordPress 6.8 Editor Tasks
Mar 21, 2025
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.8 Editor Tasks
Mar 24, 2025
github-actions
bot
removed
the
Backport to WP 6.8 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Mar 24, 2025
github-actions
bot
added
the
Backported to WP Core
Pull request that has been successfully merged into WP Core
label
Mar 24, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
PostCommentsForm: Fix submit button width regression #69651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mamaduka
merged 4 commits into
WordPress:trunk
from
im3dabasia:fix/post-comment-form-button-regression
Mar 24, 2025
Merged
PostCommentsForm: Fix submit button width regression #69651
Mamaduka
merged 4 commits into
WordPress:trunk
from
im3dabasia:fix/post-comment-form-button-regression
Mar 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im3dabasia
force-pushed
the
fix/post-comment-form-button-regression
branch
from
273bc2d to
74dc284
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Type] Regression
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 6.8 Editor Tasks
t-hamano
moved this from 🔎 Needs Review
to 🏗️ In Progress
in WordPress 6.8 Editor Tasks
t-hamano
reviewed
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I think this style is needed for both the editor and the frontend.
t-hamano
moved this from 🏗️ In Progress
to 🔎 Needs Review
in WordPress 6.8 Editor Tasks
|
@t-hamano Thank you for the feedback. I have updated the SCSS for both the frontend and editor. When you have a moment, Please check. |
t-hamano
reviewed
Mar 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
We don't need to update editor.scss because style.scss is applied to both the editor and the frontend.
Additionally, it may be a good idea to add a comment that this style is meant to override the 100% width derived from the Button block.
|
Hi @t-hamano , I updated the PR with the feedbacks you gave. |
t-hamano
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.8 Editor Tasks
github-actions
bot
removed
the
Backport to WP 6.8 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 24, 2025
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Rishit30G <rishit30g@git.wordpress.org> Co-authored-by: jessedyck <jessedyck@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: 1704d68 |
Sourav61
pushed a commit
to Sourav61/gutenberg
that referenced
this pull request
Mar 24, 2025
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Rishit30G <rishit30g@git.wordpress.org> Co-authored-by: jessedyck <jessedyck@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Rishit30G <rishit30g@git.wordpress.org> Co-authored-by: jessedyck <jessedyck@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backported to WP Core
Pull request that has been successfully merged into WP Core
[Block] Comments Form
Affects the Comments Form Block
[Type] Regression
Related to a regression in the latest release
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Closes #69637
Fixes the regression where post comment submit button stretch to full width.
Why?
In WordPress 6.8, a change to button styling (width: 100%) caused an unintended side effect on
post-comments-formsubmit button, making them stretch to full width.How?
Adds a targeted CSS rule to specifically override the width for submit button in
post-comments-formTesting Instructions
Screenshots or screencast
Before
WordPress 6.7.2
Current PR
After this change, we would have the button's width like how it was in WordPress 6.7.2 as shown in the above 2 screenshots. I tested this at 1440px width in Chrome developer tools.