You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the Site Title block from saving and rendering values made only of whitespace characters
Why?
The Site Title block was inconsistent with the classic admin behavior - it would allow saving site titles with only spaces, which created empty links on the front end. Empty links are problematic for SEO and accessibility.
This inconsistency created a situation where:
Classic admin wouldn't save site titles with only spaces
The Site Title block would save them
This would render an empty link on the frontend
How?
The solution addresses the issue in two places:
In the editor component (edit.js): Trim whitespace from the title before saving it
In the PHP render callback (index.php): Skip rendering if the site title consists only of whitespace
Testing Instructions
Use a theme that has the Site Title block on one of its templates (e.g., Twenty Twenty-Four > Blog Home template)
Go to the Site Editor and select the Site Title block
Clear the title and enter only spaces
Save the template
Check the frontend - verify no empty link is rendered
Check the classic admin (Settings > General) - verify the site title field is empty
Try to enter only spaces in the classic admin site title field and save
Verify the site title remains empty in both the classic admin and the Site Editor
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #60467
Prevents the Site Title block from saving and rendering values made only of whitespace characters
Why?
The Site Title block was inconsistent with the classic admin behavior - it would allow saving site titles with only spaces, which created empty links on the front end. Empty links are problematic for SEO and accessibility.
This inconsistency created a situation where:
How?
The solution addresses the issue in two places:
edit.js
): Trim whitespace from the title before saving itindex.php
): Skip rendering if the site title consists only of whitespaceTesting Instructions
Screencast
Before
Screen.Recording.2025-03-20.at.16.59.34.mp4
After
Screen.Recording.2025-03-20.at.17.08.16.mov