| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 09:46:19 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=421.441035,conversation_content-fragment;desc="conversation_content fragment";dur=700.770953,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=417.454969,nginx;desc="NGINX";dur=1.013149,glb;desc="GLB";dur=138.701213
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=baldhGW%2FzJ4siUmLSYSIXsVSWUTifE5OzU0grLgYOrKhMQ7HBuH5vzwmFRLWWhFCQM3E7jilkkpMCTqn5Z%2BOBHHWvKTd7ZxCSJiKt20BQ%2FzeLgrGYFiqdLXx%2Fdtl8sbO%2BoMN12I5lHEGg8B4CpWooZulIVQ4W2ra9R8sqYysVed1ZLHFUE9fm1afUwDuHiSEaoBRoykrmhT3AL0WRhYsn%2FUAH2WTpRoD83HjRbLDJPZ9Z8m%2BFBN9KuqFuy6PhBTvr6pLRqFt8zJh5MA67CGXDw%3D%3D--uDXCsc3hb0Pw7A5D--1CO7PWdGJX1iTCQxa3aAUA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.618468679.1760175978; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:46:18 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 09:46:18 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: ACD4:2994BB:540D89:719A09:68EA276A
ComboboxControl: Replace `undefined` variable usage with `color-mix` for disabled selection by yogeshbhutkar · Pull Request #69621 · WordPress/gutenberg · GitHub
ComboboxControl: Replace
ComboboxControl: Replace
Mamaduka
added
[Type] Bug
An existing feature does not function as intended
[Feature] UI Components
Impacts or related to the UI component system
labels
Mar 19, 2025
t-hamano
added
[Package] Components
/packages/components
and removed
[Feature] UI Components
Impacts or related to the UI component system
labels
Mar 19, 2025
yogeshbhutkar
force-pushed
the
fix-69593/combobox-control-disabled-state
branch
from
March 19, 2025 10:06
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
ComboboxControl: Replace undefined variable usage with color-mix for disabled selection
#69621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ciampo
merged 4 commits into
WordPress:trunk
from
yogeshbhutkar:fix-69593/combobox-control-disabled-state
Mar 19, 2025
Merged
ComboboxControl: Replace undefined variable usage with color-mix for disabled selection
#69621
ciampo
merged 4 commits into
WordPress:trunk
from
yogeshbhutkar:fix-69593/combobox-control-disabled-state
Mar 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
[Package] Components
yogeshbhutkar
force-pushed
the
fix-69593/combobox-control-disabled-state
branch
from
fe899f3 to
2e494b3
Compare
ciampo
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM 🚀 Thank you for the fix!
A nice follow-up would be to make the whole component themable
|
Thanks for the review, @ciampo.
Will follow-up on this shortly! |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…for disabled selection (WordPress#69621) * fix: remove transparent variant for accent color in theme variables * fix: use `color-mix` to derive color accent variant * fix: use `background` and reduce alpha to `4%` * chore: add changelog --- Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Components
/packages/components
[Type] Bug
An existing feature does not function as intended
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What and Why?
Closes #69593
This PR:
--wp-components-color-accent--rgbproperty as thergbvariant does not exist.$components-color-accent-transparent-40SASS variable in favor ofcolor-mix().dark backgrounds.How?
The corresponding
scssfile is updated to reflect the above changes.Testing Instructions
npm run storybook:dev)Testing Instructions for Keyboard
Same.
Screenshots
P.S. Please note that a tinted background (although faint) has been added to the first (disabled) option. The second option may appear invisible due to the lack of theming support, which will be addressed once theming is implemented for the component. (Ref. #69593 (comment))