You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #55495
Extracts getNodeText into its own file, adds unit tests, and refactors unused code.
Why?
The original implementation was merged quickly to address an accessibility issue (#47767). This PR improves maintainability by isolating the function, adding tests, and removing unnecessary code.
How?
Moved getNodeText to a separate file.
Added unit tests to verify expected behavior.
Removed redundant or unused code from the function.
Testing Instructions
Run the following command to execute unit tests for getNodeText:
npm run test:unit packages/components/src/utils/test/get-node-text.js
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
Unlinked Accounts
The following contributors have not linked their GitHub and WordPress.org accounts: @sreeragdas, @oceantober.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR: #54902
Related Issue: #55495
What?
Closes: #55495
Extracts
getNodeText
into its own file, adds unit tests, and refactors unused code.Why?
The original implementation was merged quickly to address an accessibility issue (#47767). This PR improves maintainability by isolating the function, adding tests, and removing unnecessary code.
How?
getNodeText
to a separate file.Testing Instructions
Run the following command to execute unit tests for
getNodeText
:Screenshots or screencast