You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semantically, the list of blocks in Styles > Blocks is a series of list items but it misses a wrapping list.
Why?
This is equivalent to a series of <li> elements with no wrapping <ul> element and impacts the way screen readers are expected to announce the list itself, the amount of items and position.
Observe the items are now wrapepd within an element with role="list".
Note: if you like and if you use Chrome, you can switch the DOM inspector to the accessibility tree view to better check the correct semantic structure:
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Package] Edit Site/packages/edit-site[Type] BugAn existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69025
Quick PR to add a missing ARIA role.
What?
Semantically, the list of blocks in Styles > Blocks is a series of list items but it misses a wrapping
list
.Why?
This is equivalent to a series of
<li>
elements with no wrapping<ul>
element and impacts the way screen readers are expected to announce the list itself, the amount of items and position.How?
Adds
role="list"
to the wrapping element.Testing Instructions
role="list"
.Note: if you like and if you use Chrome, you can switch the DOM inspector to the accessibility tree view to better check the correct semantic structure:
Testing Instructions for Keyboard
Screenshots or screencast