You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
The parent issue remains unresolved, and this PR aims to restore the previous behavior to fix the regression. I’d appreciate any feedback on whether this is a viable path forward or if there’s a better approach. The current implementation is based on this comment.
@yogeshbhutkar, let's rebase on top of the latest trunk. I'll try to have a look later today, but I think it is also okay to merge this bug after Beta 1.
[Feature] PatternsA collection of blocks that can be synced (previously reusable blocks) or unsynced[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).[Type] RegressionRelated to a regression in the latest release
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #68728
Alternate to #68730
This PR updates the
Patterns Modal
to close upon the insertion of aPattern
and moves the focus back to the inserted pattern.Why?
Inserter: Remove the dialog behaviour #63059.
How?
Testing Instructions
Block Inserter
navigate to thePatterns
tab.Patterns Modal
by clickingExplore all patterns
.Pattern
from theModal
to choose and observe the modal closes on selection.Screencast
pr-demo.mov