You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapping Tooltip around the Circular option picker buttons renders an unnecessary dynamic aria-describedby attribute that makes the color announcement doubled.
The tooltip visible text mismatches the actual accessible name.
Why?
Tooltips must be used to visually expose the accessible name, there shouldn't be a mismatch between the visible text and the accessible name. Also, redundant announcement are just noisy.
How?
Turns out both OptionAsOption and OptionAsButton use the Button component under the hood. This PR leverages the Button label prop to render a tooltip instead of wrapping the component within a Tooltip.
Removes the Tooltip component that wraps the buttons.
Removes the explicit aria-label attribute, also the one passed in the ColorPalette component.
Levereages the Buttons label prop by using the existing tooltipText prop as its value.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Note: The changes in this PR are pretty simple but required to adjust a pretty decent amount of tests to remove the prefix Color: from the selectors of the circular picker options. @WordPress/gutenberg-core I'd appreciate a review, when you have a chance.
* Fix usage of tooltip in the Circular option picker.
* Add changelog entry.
* Adjust tests.
* Adjust more tests.
* Adjust one more test.
* Update test snapshot.
* Adjust more tests.
* Adjust more tests.
* Adjust one more test.
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
* Fix usage of tooltip in the Circular option picker.
* Add changelog entry.
* Adjust tests.
* Adjust more tests.
* Adjust one more test.
* Update test snapshot.
* Adjust more tests.
* Adjust more tests.
* Adjust one more test.
Co-authored-by: afercia <afercia@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68601
What?
Why?
Tooltips must be used to visually expose the accessible name, there shouldn't be a mismatch between the visible text and the accessible name. Also, redundant announcement are just noisy.
How?
Turns out both
OptionAsOption
andOptionAsButton
use the Button component under the hood. This PR leverages the Buttonlabel
prop to render a tooltip instead of wrapping the component within a Tooltip.ColorPalette
component.label
prop by using the existingtooltipText
prop as its value.Testing Instructions
aria-describedby
attribute added to the currently focused color button.Testing Instructions for Keyboard
Screenshots or screencast