You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR applies the appropriate label to aria-valuetext when the BoxControl component has presets, allowing screen readers to properly announce the preset values.
Why?
The aria-valuenow attribute is used in a range widget to communicate the current value, and the aria-valuetext attribute is used to provide more human-readable text.
The current implementation references the label field, which is always an empty string, so aria-valuetext is effectively non-functional.
How?
From my understanding, the reason the label field is empty is because we do not want to display a visual mark label, so the label field should be left empty. Instead, apply the tooltip text to aria-valuetext as well, so that the text read by screen readers matches the visual tooltip text.
Flaky tests detected in 8c0bc3d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #67688
What?
This PR applies the appropriate label to
aria-valuetext
when theBoxControl
component has presets, allowing screen readers to properly announce the preset values.Why?
The
aria-valuenow
attribute is used in a range widget to communicate the current value, and thearia-valuetext
attribute is used to provide more human-readable text.The current implementation references the
label
field, which is always an empty string, soaria-valuetext
is effectively non-functional.How?
From my understanding, the reason the
label
field is empty is because we do not want to display a visual mark label, so thelabel
field should be left empty. Instead, apply the tooltip text toaria-valuetext
as well, so that the text read by screen readers matches the visual tooltip text.This should match the implementation of the
SpacingSizesControl
component.Testing Instructions
npm run storybook:dev
aria-valuetext
attribute via your browser developer tools.Screenshots or screencast
3ade381fd967ce06444a3114e4b32a39.mp4