You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starts logging a deprecation warning for Navigation, with an explicit end version.
Why?
After passive deprecating (#61099) this component, we have had to do maintenance work on it many times. Given the low usage, I think it would be beneficial to eventually hard remove this code from the codebase.
Testing Instructions
✅ Deprecation warning should be logged in the Storybook.
✅ Unit tests should pass.
✍️ Dev Note
The Navigation component (and all its subcomponents) are deprecated, planned for hard removal in WordPress 7.1. Use the Navigator component instead.
mirka
added
has dev note
when dev note is done (for upcoming WordPress release)
and removed
Needs Dev Note
Requires a developer note for a major WordPress release cycle
labels
Dec 20, 2024
Flaky tests detected in 6c8070a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mirka
added
[Type] Code Quality
What?
Starts logging a deprecation warning for
Navigation, with an explicit end version.Why?
After passive deprecating (#61099) this component, we have had to do maintenance work on it many times. Given the low usage, I think it would be beneficial to eventually hard remove this code from the codebase.
Testing Instructions
✅ Deprecation warning should be logged in the Storybook.
✅ Unit tests should pass.
✍️ Dev Note
The
Navigationcomponent (and all its subcomponents) are deprecated, planned for hard removal in WordPress 7.1. Use theNavigatorcomponent instead.