You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#67705 made the reset button in the shadow panel visible only on hover. However, I found that it was not possible to remove the shadow on devices that don't support hover. Therefore, I made the reset button visible on all devices that don't support hover.
Testing Instructions
Site Editor > Global Styles > Shadows > Add shadow preset > Add multiple shadow value
Desktop layout: The reset button is only visible on hover.
Mobile Device (Can be simulated using browser developer tools): The reset button is always visible.
The reason will be displayed to describe this comment to others. Learn more.
I needed to increase the specificity of the style to reset the border, otherwise the border would remain below the button in the mobile layout.
t-hamano
changed the title
Shadows: Always show reset button If hover is not supported
Shadows: Always show reset button if hover is not supported
Dec 19, 2024
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
t-hamano
added
[Type] Bug
An existing feature does not function as intended
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Dec 19, 2024
The reason will be displayed to describe this comment to others. Learn more.
Thanks Aki. This is testing great on my end.
Screen.Recording.2024-12-19.at.10.21.45.mov
I'm wondering if we should do the same for the other resets we've implemented, for consistency. Although there's more than one "reset" options on those cases.
I'm wondering if we should do the same for the other resets we've implemented, for consistency. Although there's more than one "reset" options on those cases.
Yes, I think we need to. For example, the reset button added by #67116 is not touchable on devices that don't support hover. The "Clear" button is available in the dropdown, but it may be better to always show the reset button, as in this PR.
Flaky tests detected in b41852a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
[Focus] Accessibility (a11y)Changes that impact accessibility and need corresponding review (e.g. markup changes).Global StylesAnything related to the broader Global Styles efforts, including Styles Engine and theme.json[Type] BugAn existing feature does not function as intended
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #67705
What? Why? How?
#67705 made the reset button in the shadow panel visible only on hover. However, I found that it was not possible to remove the shadow on devices that don't support hover. Therefore, I made the reset button visible on all devices that don't support hover.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast