You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check any usage of the ContrastChecker, and make sure there are no slot / fill implementations where additional controls may be added between the color settings and the ContrastChecker.
To my understanding, the Navigation and Social Links blocks use ContrastChecker directly rather than BlockColorContrastChecker so they aren't affected.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Flaky tests detected in cd423ea.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
Weighing the potential of the position of the contrast checker being incorrect, and fixing the WCAG violation, fixing the later is more important, and it should not be delayed.
afercia
changed the title
Remove unnecessary CSS order property for the contrast checker in the…
Remove unnecessary CSS order property for the contrast checker in the Color hook
Jan 10, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58936
What?
Part of ongoing effort to remove any
order
CSS property from the codebase.Why?
The
order
CSS property must not be used to alter the visual order in s way that affects meaning and interaction.How?
Removes the
order
property.Testing Instructions
Navigation
andSocial Links
blocks useContrastChecker
directly rather thanBlockColorContrastChecker
so they aren't affected.Testing Instructions for Keyboard
Screenshots or screencast