| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 12 Oct 2025 10:14:15 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=429.302469,conversation_content-fragment;desc="conversation_content fragment";dur=566.371576,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=345.562319,nginx;desc="NGINX";dur=1.237252,glb;desc="GLB";dur=138.357231
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=kfDhh6spwgktAXhluJgzxpyb%2BZ0%2FMlUKbRcMju0wHU60vw2eG1gDVrDhTZPnK8ZQkltXsnlMgguyQng4LQBwEorJPrvL%2Fpeokxj0aKiKU0qZljL35YrXNbkbBttm6TLHavEyJvZ%2BFya%2B1toZD4SXv1HyeguvnY%2BWql7w6IlbuZoVdQZYG65TKuavNLu97R9IQC3blEpadrjWh8sUI%2Fam6M%2FKxZXpNto00GfJ%2Fsys1SkQdmurayT91Hfr%2FOmhP5lb%2BuosPQT0pp4P%2BkAss%2FGHPA%3D%3D--hzAcoqU4JVghsJu9--Dy%2FRwR4ANDY3hElFxk428w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.640262962.1760264054; Path=/; Domain=github.com; Expires=Mon, 12 Oct 2026 10:14:14 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 12 Oct 2026 10:14:14 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E07E:136466:E49734:1316D51:68EB7F76
[core-data]: Fix TS types for user object by manzoorwanijk · Pull Request #68045 · WordPress/gutenberg · GitHub
manzoorwanijk
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Core data
/packages/core-data
labels
Dec 17, 2024
manzoorwanijk
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar,
ndiego and
nerrad
as code owners
December 17, 2024 11:03
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[core-data]: Fix TS types for user object #68045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzoorwanijk
added
[Type] Code Quality
manzoorwanijk
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar,
ndiego and
nerrad
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Dec 17, 2024
|
Flaky tests detected in 8de2b23. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17725084572
|
Mamaduka
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, @manzoorwanijk!
The changes make sense. The REST API will use the default context view when the query argument isn't specified. The entities set the default context as part of baseURLParams, but that's not the case for the current user resolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Core data
/packages/core-data
[Type] Code Quality
Issues or PRs that relate to code quality
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR solves two issues
getCurrentUserselector's return type is set toET.User< 'edit' >, which sets the incorrect return type with properties that don't exist on the current user object, for example,user.capabilities. The return type should rather beET.User< 'view' >because that is whatstate.currentUseris, as mentioned in Convert core-data selectors from jsDoc annotations into TypeScript type signatures #40025 (comment)Here, you can see the difference between a current user (
users/me) and a normal user (users/<id>) object.user.capabilitiesis set toRecord< string, string >, which is incorrect. It should rather beRecord< string, boolean >, because those capabilities come from here as pointed out in Core Data: TypeScript definitions for entity records. #38666 (comment)What?
getCurrentUserselector.user.capabilitiesto be a record of booleans instead of a record of strings.Why?
To fix the incorrect types
How?
By fixing the types
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast