| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 07:14:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=1970.945679,conversation_content-fragment;desc="conversation_content fragment";dur=912.385698,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=252.562287,nginx;desc="NGINX";dur=0.402513,glb;desc="GLB";dur=147.42843
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=o06yc0TLf5LTnfAiNuDyxTBsbKuEuvvar7Z13u0msJgMRjZNDW89Dd1ClyynLS4%2FdtWhGu2SZnUG7WTkDB9uRswNRX7CMl9TF0qkBCNd0Urf4%2BJTwIn4aI4kDH0YDOz6nlhBTZeaOT8pp2CQ5NEfgWNXa33b2mpxxayMBNOIxiKjlXgxq3zTHPVq4BWprqhEISE%2Faq9k25MLOwf5O9oL99VVkOO4rLSiaK01hOr%2FM177xOO11k2evooZVgqoO8566IqAJAlWBPHj5AvQpGwr4Q%3D%3D--4AuMfm1vqiai%2FKdW--O%2Bqx2mqd6yCtVu6m8xXbKg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1058407240.1760080465; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 07:14:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 07:14:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9F94:23EB94:1554778:19B3767:68E8B251
Fix: Templates and patterns are nesting two elements with the button role by jorgefilipecosta · Pull Request #67801 · WordPress/gutenberg · GitHub
jorgefilipecosta
added
[Type] Bug
An existing feature does not function as intended
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
labels
Dec 10, 2024
jorgefilipecosta
force-pushed
the
fix/templates-and-patterns-nest-two-element-with-a-role-of-button
branch
from
December 11, 2024 10:40
jorgefilipecosta
deleted the
fix/templates-and-patterns-nest-two-element-with-a-role-of-button
branch
December 11, 2024 11:00
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix: Templates and patterns are nesting two elements with the button role #67801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorgefilipecosta
merged 2 commits into
trunk
from
fix/templates-and-patterns-nest-two-element-with-a-role-of-button
Dec 11, 2024
Merged
Fix: Templates and patterns are nesting two elements with the button role #67801
jorgefilipecosta
merged 2 commits into
trunk
from
fix/templates-and-patterns-nest-two-element-with-a-role-of-button
Dec 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -315 B (-0.02%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ee0409c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12261313073
|
oandregal
approved these changes
Dec 11, 2024
|
Before this change, the media field of the grid layout in the Patterns screen had an extra non-interactive stop: Screen.Recording.2024-12-11.at.10.11.03.movAfter the change, it doesn't: Screen.Recording.2024-12-11.at.10.08.35.mov |
jorgefilipecosta
force-pushed
the
fix/templates-and-patterns-nest-two-element-with-a-role-of-button
branch
from
ee0409c to
001466e
Compare
jorgefilipecosta
deleted the
fix/templates-and-patterns-nest-two-element-with-a-role-of-button
branch
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…role (WordPress#67801) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Type] Bug
An existing feature does not function as intended
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
If an element has the role of button its accessibility tree can not have a button inside. Essentially that would mean we have a button inside each other.
On the template and patterns grid view, we are nesting a button inside another button for each of the grid items. This PR fixes the issue by removing the inner button. By doing that we can also remove multiple styles that are now automatically handled by data views.
Previous markup
After markup