You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The utility .screen-reader-text CSS is used in several places throughout the Gutenberg code base. In #65409 it came up that we should update all the areas to match the changing CSS rules proposed in #65409.
How?
Remove the unnecessary clip: rect(1px, 1px, 1px, 1px); and -webkit-clip-path: inset(50%); rules from the packages/block-library/src/components/downloadable-block-list-item/style.scss
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mediaformat! In case you missed it, we'd love to have you join us in our Slack community.
If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
mediaformat
changed the title
Remove clip & -webkit-clip-path for screen-reader-text CSS
Remove clip & -webkit-clip-path for downloadable-block-list-item style.scss
Oct 15, 2024
Thanks @mediaformat
I think this rulest can be entirely replaced with a display: none. Currently, this rule is only set when a block from the blocks directory in the main inserter is in the process of being installed.
It is meant to temporarily hide the block author name when isInstalling is true. After the block is installed, the author name is visible again. Anyways, the whole content of the button in the inserter is overridde by the aria-label set on the button so there's really no need to use the screen-reader-text rule on the author name.
Open the main inserter.
Search for some term e.g. image
Scroll down the inserter and observe the Available to install section. Note: this is the blocks directory. It takes a while to load.
Choose one of the blocks from the blocks directory and click to install it.
Observe the content of the block item in the list changes and shows an Installing... text.
Observe the original content of the block item is visible again when the block is installed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses part of #65954
Why?
The utility .screen-reader-text CSS is used in several places throughout the Gutenberg code base. In #65409 it came up that we should update all the areas to match the changing CSS rules proposed in #65409.
How?
Remove the unnecessary clip: rect(1px, 1px, 1px, 1px); and -webkit-clip-path: inset(50%); rules from the packages/block-library/src/components/downloadable-block-list-item/style.scss
Style attribute