| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 15:47:49 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=368.599637,conversation_content-fragment;desc="conversation_content fragment";dur=946.64958,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=302.660476,nginx;desc="NGINX";dur=1.220617,glb;desc="GLB";dur=140.395721
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=889yVKzl53qXR7WpvPQ8Zm%2FRSEDS5NartiYvNhIvuuHWClsWbidowE%2FuweQ5K9503pCMaAZTqfX6Zdwe51Eqq6rt34xpq%2Bm0u%2BsYWT5CwqaNgjsCHEux7NlvMGkhfJ32ZGT3j48UwK483mH7n1pIbxPo%2Bcm%2FT%2FhGiBQ0NiICFupm7EsVEeed%2BeDNUNduXLozugu7NPFo1vGLBbP7ACh7goqZyy2eW%2BD3avBrgtX2CNh9jD6WhErmoYMWAR%2FgdEye1goWdRRhKY597ZF0wjGwVg%3D%3D--c%2BxlyGknIJKs9djH--dgEDRRgOc2yJAdqZth%2FWvQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1597077422.1760197668; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:47:48 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 15:47:48 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D2C4:2C8153:827055:AB83D8:68EA7C24
Match visible label of search inputs with their actual label. by afercia · Pull Request #65458 · WordPress/gutenberg · GitHub
afercia
added
[Type] Bug
An existing feature does not function as intended
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
[Package] Editor
/packages/editor
[Package] Block library
/packages/block-library
[Package] Block editor
/packages/block-editor
[Package] Edit Site
/packages/edit-site
labels
Sep 18, 2024
afercia
requested review from
ajitbohra,
ellatrix and
getdave
as code owners
September 18, 2024 14:19
afercia
force-pushed
the
fix/search-inputs-placeholder-label-mismatch
branch
from
September 19, 2024 08:02
afercia
force-pushed
the
fix/search-inputs-placeholder-label-mismatch
branch
from
October 4, 2024 11:41
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Match visible label of search inputs with their actual label. #65458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
afercia
requested review from
ajitbohra,
ellatrix and
getdave
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -84 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/search-inputs-placeholder-label-mismatch
branch
from
0760edd to
7c5dc4e
Compare
afercia
force-pushed
the
fix/search-inputs-placeholder-label-mismatch
branch
from
7c5dc4e to
9f86d17
Compare
|
The labels changed in this PR are not visible, so this seems fine to me if it improves a11y. |
|
Thanks @jameskoster. I'd appreciate a final review and approval Cc @WordPress/gutenberg-core |
mirka
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense 👍 Thanks for the sweep, and I'll add a note for myself to include this in the design guidelines.
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ess#65458) * Match visible label of search inputs with their actual label. * Adjust more tests. * Adjust more tests. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Component System
WordPress component system
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Needs Design Feedback
Needs general design feedback.
[Package] Block editor
/packages/block-editor
[Package] Block library
/packages/block-library
[Package] Edit Site
/packages/edit-site
[Package] Editor
/packages/editor
[Type] Bug
An existing feature does not function as intended
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #65235
What?
The visible label of some search inputs mismatches their actual accessible name.
This is a barrier for some users, most notably sighted screen reader users and voice control users.
Why?
Important
It is worth reminding a few principles:
I would like the principles above to be included in the design guidelines Cc @WordPress/gutenberg-design
How?
SearchControland other search inputs use the same text for the label and the placeholder.ria-labelledbyis meant to be user to point to visible text. See Visually hide the LinkControl initial/results heading #50977 (comment)Testing Instructions
SuggestionsSearch results for "%s"Testing Instructions for Keyboard
Screenshots or screencast