Size Change: -53 B (0%)

Total Size: 1.94 MB

_{compressed-size-action}

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ockham <bernhard-reiter@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: michalczaplinski <czapla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ockham, do you mind rebasing this on top of the latest trunk?

@ockham, do you mind rebasing this on top of the latest trunk?

Done!

I'm seeing a minor issue but I'm not 100% sure if I'm using the feature correctly. This is my variation registration code in my custom block:

// `index.js` of my custom block
import { registerBlockVariation } from "@wordpress/blocks";
import { __ } from "@wordpress/i18n";
import domReady from "@wordpress/dom-ready";
domReady(() => {
	registerBlockVariation("core/group", {
		name: "wpcomsp/marquee-content",
		title: "Marquee Content",
		icon: "editor-table",
		description: __("A marquee content block."),
		scope: ["block", "inserter"],
		attributes: {
			isMarquee: true,
			layout: { type: "flex", flexWrap: "nowrap" },
			className: "wpcomsp-marquee-content",
			allowedBlocks: [
				"core/paragraph",
				"core/heading",
				"core/image",
				"core/buttons",
			],
		},
		isActive: ["layout.type", "isMarquee"],
	});
});

I can see the Marquee Content block in the inserter, but upon inserting I get the Row block instead.

Curiously, when I increase the specificity by adding an additional item in the isActive array like "layout.flexWrap", it seems to work correctly for the Marquee Content block:

  isActive: ["layout.type", "layout.flexWrap", "isMarquee"],

But, trying to insert a Row block ends up inserting a Marquee Content instead.

I can see the Marquee Content block in the inserter, but upon inserting I get the Row block instead.

Oh, that's very weird, and somewhat concerning -- the block variation inserted being different from the one selected in the inserter seems like there's a very weird disconnect happening.

I'm curious, what happens if you try using your code with GB trunk?

I did more testing and noticed that normal Group variation (layout.type === 'constrained') is no longer marked as active in the sidebar, while it displays correct labels.

I did more testing and noticed that normal Group variation (layout.type === 'constrained') is no longer marked as active in the sidebar, while it displays correct labels.

Ah, good spot! I opted against setting isActive to [ 'layout.type' ] as the original criterion also allowed for another value (default), as well as for the nested attribute to be missing altogether. I was expecting that isDefault would be used to determine the fallback if no variation matches, but that's apparently not the case.

I'm thinking to implement the latter behavior (potentially in a separate PR).

I'm thinking to implement the latter behavior (potentially in a separate PR).

#63858

Flaky tests detected in 90682ac.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17733383507
📝 Reported issues:

• [Flaky Test] Redirection after template creation #60678 in /test/e2e/specs/site-editor/site-editor-url-navigation.spec.js
• [Flaky Test] should refresh the page when stylesheet loading fails #71722 in /test/e2e/specs/interactivity/router-styles.spec.ts

@Mamaduka Think this is good to land?