| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 23:42:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=465.998659,conversation_content-fragment;desc="conversation_content fragment";dur=1552.122798,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=397.283184,nginx;desc="NGINX";dur=0.669353,glb;desc="GLB";dur=138.08841
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=MhR4a%2B7r4V052iRl19FvYS6q2GgRNuzmfkJK0q1auSxUSTGsrg3PBPlAV7%2B9gvNbOgIjIHkhnV%2F5B7urZnhUql1A47KJKq8mLlOAfFeD7BAetuuPYFZLIj30OfXxP6Ru96a5JNZS7pJRr2x3iIphfUf012hdTfJDdVbuZdZMXcC%2BoxFL9fguux0AOSjGc6mLhBwVy%2FP%2BCubL5eJ2lUg%2BZitbRsG51Yj4ne5yb4%2FApcFVjfNhfD3x%2Bdjbw4GJANvarK0xmJOhgYrNkALztrqheA%3D%3D--12qHEdn3uCm5%2FHWa--%2BxgfGKS0MKet%2BUd0jCgrmA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1831699023.1760139777; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 23:42:57 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 23:42:57 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B568:E3EA6:1722BE:21543D:68E99A01
Fix e2e test for block API / filtered blocks by stokesman · Pull Request #51882 · WordPress/gutenberg · GitHub
stokesman
added
the
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
label
Jun 26, 2023
stokesman
force-pushed
the
fix/e2e-block-api
branch
from
July 6, 2023 00:59
Mamaduka
force-pushed
the
fix/e2e-block-api
branch
from
May 29, 2025 13:03
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix e2e test for block API / filtered blocks #51882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
the
[Type] Automated Testing
|
For reference the PR that introduced the test. I requested a review from Greg because he's the author. |
stokesman
commented
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference here’s the filter source:
gutenberg/packages/e2e-tests/plugins/block-api/index.js
Lines 17 to 31 in fe28cc9
| addFilter( | |
| 'blocks.registerBlockType', | |
| 'e2e-tests/hello-world/filter-added-after-registration', | |
| ( blockType, name ) => { | |
| if ( name === 'e2e-tests/hello-world' ) { | |
| return { | |
| ...blockType, | |
| title: 'Filtered Hello World', | |
| }; | |
| } | |
| return blockType; | |
| } | |
| ); | |
| } )(); |
It doesn't filter block content but rather the block title. So that's why I thought the assertion should be for the filtered title.
|
Size Change: 0 B Total Size: 1.85 MB ℹ️ View Unchanged
|
stokesman
force-pushed
the
fix/e2e-block-api
branch
from
1006955 to
b02c0bd
Compare
|
Flaky tests detected in b02c0bd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5470416292
|
Mamaduka
force-pushed
the
fix/e2e-block-api
branch
from
b02c0bd to
c22e28a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Sorry for the branch override, @stokesman! I found this PR while cleaning old draft branches and decided to finish it instead of closing it. |
Mamaduka
approved these changes
May 29, 2025
|
Thank you @Mamaduka! |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
An attempt to fix a test that may not be doing what it's supposed to be. Noticed during work on #51824.
Why?
It's worth a look because the test might not guard against regressions.
Currently the test asserts that the filtered block is inserted and has a certain text content. I suspect that’s wrong because the filter doesn't change the text content so there’s nothing testing the filter had an effect.
Conversely, if the original issue was that a block would fail to be inserted if it had a filter added after its block type was registered, then this test is fine and this PR can be closed. However, that didn't seem to be the case from my reading of it.
How?
Creates an assertion for the effect of the filter.
Testing Instructions