| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 23:44:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=258.414252,conversation_content-fragment;desc="conversation_content fragment";dur=858.934673,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=275.261572,nginx;desc="NGINX";dur=0.694665,glb;desc="GLB";dur=137.09768
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=%2ByouDbZD5%2FryoHnhMg1sU3HoLDd64Y8KhU5TOIWtlNv1KbxebEVjFQm0cXGcP3ASo9LphrKga%2BG5QwOGyTzQ2gttHH8%2Fz%2FEvy97bG3yarxYGbY083DjFGvBbDLYIxhRf8Dc4mLmRPOyZhJCzBKjz7m73wUgdOgSUMsxx92xfXxmaCTI0Hiq%2BaIasYrhq6kObkCezayGZzvlADCemBoLAXGqpVoK3tmcrZgDdT1HVTqrJKstQp1p4Bj6ZF8XtuW1f%2Fa%2Bu1Vrpi8b7paAgV%2B7ufQ%3D%3D--AmBPpc5Q6F123RfK--E6Z6%2BhdzVsFcSTg492nE1g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.902989477.1760226262; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 23:44:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 23:44:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D688:136466:AA9FDA:E322D1:68EAEBD6
Webfonts API: Document `fontFace` and it’s values in `theme.json` schema by grappler · Pull Request #41844 · WordPress/gutenberg · GitHub
Webfonts API: Document
grappler
changed the title
Document fontFace and it’s values in
Webfonts API: Document fontFace and it’s values in Jun 21, 2022
grappler
changed the title
Webfonts API: Document fontFace and it’s values in
Webfonts API: Document Jun 21, 2022
grappler
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
June 21, 2022 23:32
Mamaduka
added
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Jun 27, 2022
adamziel
removed
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Jun 30, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Webfonts API: Document fontFace and it’s values in theme.json schema
#41844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grappler
changed the title
theme.json schematheme.json schema
grappler
changed the title
theme.json schemafontFace and it’s values in theme.json schema
Closed
5 tasks
grappler
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar and
ryanwelcher
as code owners
fabiankaegy
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition :) Added one comment. But that can also happen in a follow up 👍
|
It would be great if this could be backported to wp/6.0 too. Happy to create a second PR for that. |
|
@adamziel, I think this needs to be backported so that the schema URL is correctly resolved. It's not a blocker for a minor release. |
Mamaduka
added
the
Backport to WP Minor Release
adamziel
pushed a commit
that referenced
this pull request
Jun 30, 2022
…ema (#41844) * Document fontFace and it’s values in theme.json schema * npm run docs:build * Fully document all options * required & additionalProperties placed incorrectly * Missing properties and small fixes * Remove extra space * Font-weight is not required * Font weight can be either a string or an integer
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 6a79add |
adamziel
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Document the
fontFaceproperties that we introduced in WordPress 6.0 as part of the WebFonts API.Why?
Because there is no documentation.
How?
By including the basic technical documentation to the
theme.jsonschema.Testing Instructions
Create a
theme.jsonand paste the following in the code. Currently, it says that thefontFaceis not allowed. Replacehttps://schemas.wp.org/trunk/theme.jsonwithhttps://raw.githubusercontent.com/grappler/gutenberg/schema-fontFace/schemas/json/theme.jsonto test changes.`theme.json` code
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 2, "settings": { "typography": { "fontFamilies": [ { "fontFamily": "\"Source Serif Pro\", serif", "name": "Source Serif Pro", "slug": "source-serif-pro" }, { "fontFamily": "\"Inter\", sans-serif", "name": "Inter", "slug": "inter", "fontFace": [ { "fontFamily": "Inter", "fontWeight": "200 900", "fontStyle": "normal", "fontStretch": "normal", "src": [ "file:./assets/fonts/inter/Inter.ttf" ] } ] } ] } } }Screenshots