| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 12 Oct 2025 11:23:38 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=317.858738,conversation_content-fragment;desc="conversation_content fragment";dur=683.094194,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=351.226216,nginx;desc="NGINX";dur=1.458414,glb;desc="GLB";dur=141.060328
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=QgnbZMavysZ30XyOwbJBwQm99Zw7LZ37JDomCqncRl3n53Za%2BbS7NEsenBMFhhqddlWy8GiDjbCLqOXdFYS%2FgmxgOOl2%2BdnuMbtQXaaBe97aaoOke13%2FveVvdyfLbDTUynX8iDYcwdlzevafWXYHzTlE%2B%2FwVlyj8PS5I%2Bf9C3cbdhE4ASCg9ddDl3QTOSJ1Jij1xpNddsWst8BVL3pkYFTh%2BrKE5AuVUqF1XpxUDlhv6nvFGmPzv%2FdYfK7qo6%2B3M6yEolLr2OsHOC3480O%2FUHw%3D%3D--cSbelUs%2BWzKpyJvx--eZPbKBcG0wzihCJvpflUGA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1383457129.1760268217; Path=/; Domain=github.com; Expires=Mon, 12 Oct 2026 11:23:37 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 12 Oct 2026 11:23:37 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 963E:2DA241:4365E4:5AEDE5:68EB8FB9
Lower the priority of the gallery gap css so it loads after the block layout css by glendaviesnz · Pull Request #41423 · WordPress/gutenberg · GitHub
glendaviesnz
added
[Type] Bug
An existing feature does not function as intended
[Block] Gallery
Affects the Gallery Block - used to display groups of images
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
labels
May 30, 2022
adamziel
removed
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Jun 21, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Lower the priority of the gallery gap css so it loads after the block layout css #41423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
andrewserong
approved these changes
May 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea @glendaviesnz, this looks like a simple way to fix the issue in the short-term to me!
✅ The gallery block spacing feature still appears to work correctly in the post and site editors with a block theme.
✅ In a classic theme, adding in a rule like :root { --wp--style--gallery-gap-default: 46px; } in the frontend and editor CSS allowed for overriding the gallery gap's default 0.5em on the site frontend and within the editor.
| Before | After |
|---|---|
 |
 |
LGTM!
ramonjd
approved these changes
May 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @andrewserong said 😄
Tested in block/classic themes the latter by adding --wp--style--gallery-gap-default + value to the :root selector in frontend and editor stylesheets.
Tested on 2021, 2020 and 2022 WordPress themes.
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
… layout css (#41423) Co-authored-by: Glen Davies <glen.davies@a8c.com>
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 10f347a |
adamziel
pushed a commit
that referenced
this pull request
Jun 21, 2022
… layout css (#41423) Co-authored-by: Glen Davies <glen.davies@a8c.com>
adamziel
removed
the
Backport to WP Minor Release
|
@glendaviesnz this PR contains PHP changes that need a matching PR in the https://github.com/WordPress/wordpress-develop repository to be included in WordPress 6.0.1. Would you please create such a PR? CC @SergeyBiryukov |
|
@adamziel WordPress/wordpress-develop#2839 - I assume we branch of 6.0 for this, but let me know if this was the wrong assumption and I will redo the PR |
|
@glendaviesnz I just commented on the other PR, we're good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Gallery
Affects the Gallery Block - used to display groups of images
[Type] Bug
An existing feature does not function as intended
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Fixes the order that the Gallery gap CSS is enqueued so it is not overwritten by layout CSS in non block themes
Why?
Currently for non-block themes the Gallery block gap CSS is being loading prior to the layout CSS, so the gap value is overwritten by the default 0.5em value
How?
Set the action priority lower in the Gallery render method. This issue is also fixed by #41015, but this smaller change may be easier to backport to 6.0.1?
Testing Instructions
--wp--style--gallery-gap-default: 37px;37pxScreenshots
Before:
After:
