| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 14 Oct 2025 09:48:01 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=358.888654,conversation_content-fragment;desc="conversation_content fragment";dur=1159.204757,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=482.234945,nginx;desc="NGINX";dur=0.865911,glb;desc="GLB";dur=139.532851
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=z5PFkvvWYxy1uPMtOlEpT6LlVpJFn9eQLWOOf31NIcKEFgLKnVjKXliS7LJX%2BbMokroV7TFU6qU1rzgsu2ZI5ZRl4FhRyRgSZ7NA0AOG8lCjF%2F4YPO0gqIKO1BZeIxqtTZoroMn1XVxSQRxlaxlAGM5jaCkHn2TzLvGe%2BXi2gfeehRQpqzg%2FIPsgsSfXBbkPV4PdIBK9CrrnI8wi%2BNTmm2Ldtzjv2Wp17rfdK7w0Lzw%2BrzrAi97pRJp7MwXXs9uOcDZxHv%2FDjoyo9v5C9eYGSg%3D%3D--RzdAwGxUwyEyvd3Q--bM74E3WlreGWCI%2FYrYydVg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2097645579.1760435280; Path=/; Domain=github.com; Expires=Wed, 14 Oct 2026 09:48:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 14 Oct 2026 09:48:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E3E6:35FB05:80F18E:9B65AB:68EE1C50
Refactor: Reuse code of the editor placeholder across Post Comments and Post Comments Form by michalczaplinski · Pull Request #40560 · WordPress/gutenberg · GitHub
michalczaplinski
added
[Block] Comments Form
Affects the Comments Form Block
[Block] Comments (legacy)
The legacy mode of the Comments block (formerly known as Post Comments)
labels
Apr 22, 2022
michalczaplinski
changed the title
Reuse code of the editor placeholder across Post Comments and Post Comments Form
Refactor: Reuse code of the editor placeholder across Post Comments and Post Comments Form
Apr 22, 2022
ndiego
added
the
Backport to WP 6.8 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Apr 25, 2022
adamziel
removed
the
Backport to WP 6.8 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Apr 25, 2022
ockham
added
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
May 31, 2022
adamziel
removed
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Jun 21, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Refactor: Reuse code of the editor placeholder across Post Comments and Post Comments Form #40560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -128 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
michalczaplinski
added
[Block] Comments Form
michalczaplinski
changed the title
cbravobernal
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
luisherranz
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
|
Thanks a lot @michalczaplinski! 🚀 |
ndiego
added
the
Backport to WP 6.8 Beta/RC
adamziel
removed
the
Backport to WP 6.8 Beta/RC
|
While it's just a code change, it'd be nice if we could backport this for WP 6.0.1 in order to facilitate other fixes planned for the point release (i.e. fewer conflicts when applying patches etc). |
ockham
added
the
Backport to WP Minor Release
adamziel
added a commit
that referenced
this pull request
Jun 21, 2022
…nd Post Comments Form (#40560) * Create a separate template for the Comments Form * Use the form in the Post Comments block * Add the missing "return" in the CommentForm
|
I just cherry-picked this PR to the wp/6.0 branch to get it included in the next release: 7e7d6cd |
adamziel
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Comments Form
Affects the Comments Form Block
[Block] Comments (legacy)
The legacy mode of the Comments block (formerly known as Post Comments)
[Type] Code Quality
Issues or PRs that relate to code quality
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What?
Create a
CommentsFormcomponent that is re-used in the editor across both Post Comments and the Post Comments Form blocks.This PR has no functional changes, it's a refactoring.
Why?
This is based on suggestion by @ockham in #40484 (review)
Previously, there was a duplication of code between the Post Comments and the Post Comments Form blocks.
Testing Instructions