Navigation Link, Navigation Submenu: Remove the title attribute controls (#69689)

Infinite-Null · Infinite-Null · t-hamano · web-flow · commit 6985f08c079f · 2025-04-02T17:24:05.000+09:00
* Remove Title attribute controls

* Remove Title controls from Image component

* Remove 'title' attribute from navigation link and submenu blocks

* Remove title attribute checks from custom sources tests

* Revert image changes

* Remove `title` attribute from navigation link and submenu blocks

Co-authored-by: Infinite-Null &lt;ankitkumarshah@git.wordpress.org&gt;
Co-authored-by: t-hamano &lt;wildworks@git.wordpress.org&gt;
Co-authored-by: carolinan &lt;poena@git.wordpress.org&gt;
Co-authored-by: joedolson &lt;joedolson@git.wordpress.org&gt;
diff --git a/docs/reference-guides/core-blocks.md b/docs/reference-guides/core-blocks.md
@@ -484,7 +484,7 @@ Add a page, link, or another item to your navigation. ([Source](https://github.c
 -	**Parent:** core/navigation
 -	**Allowed Blocks:** core/navigation-link, core/navigation-submenu, core/page-list
 -	**Supports:** interactivity (clientNavigation), typography (fontSize, lineHeight), ~~html~~, ~~renaming~~, ~~reusable~~
--	**Attributes:** description, id, isTopLevelLink, kind, label, opensInNewTab, rel, title, type, url
+-	**Attributes:** description, id, isTopLevelLink, kind, label, opensInNewTab, rel, type, url
 
 ## Submenu
 
@@ -494,7 +494,7 @@ Add a submenu to your navigation. ([Source](https://github.com/WordPress/gutenbe
 -	**Category:** design
 -	**Parent:** core/navigation
 -	**Supports:** interactivity (clientNavigation), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~
--	**Attributes:** description, id, isTopLevelItem, kind, label, opensInNewTab, rel, title, type, url
+-	**Attributes:** description, id, isTopLevelItem, kind, label, opensInNewTab, rel, type, url
 
 ## Page Break
 
diff --git a/packages/block-library/src/navigation-link/block.json b/packages/block-library/src/navigation-link/block.json
@@ -35,9 +35,6 @@
 		"url": {
 			"type": "string"
 		},
-		"title": {
-			"type": "string"
-		},
 		"kind": {
 			"type": "string"
 		},
diff --git a/packages/block-library/src/navigation-link/edit.js b/packages/block-library/src/navigation-link/edit.js
@@ -174,7 +174,7 @@ function getMissingText( type ) {
  * Consider reusing this components for both blocks.
  */
 function Controls( { attributes, setAttributes, setIsLabelFieldFocused } ) {
-	const { label, url, description, title, rel } = attributes;
+	const { label, url, description, rel } = attributes;
 	return (
 		<ToolsPanel label={ __( 'Settings' ) }>
 			<ToolsPanelItem
@@ -239,27 +239,6 @@ function Controls( { attributes, setAttributes, setIsLabelFieldFocused } ) {
 				/>
 			</ToolsPanelItem>
 
-			<ToolsPanelItem
-				hasValue={ () => !! title }
-				label={ __( 'Title attribute' ) }
-				onDeselect={ () => setAttributes( { title: '' } ) }
-				isShownByDefault
-			>
-				<TextControl
-					__nextHasNoMarginBottom
-					__next40pxDefaultSize
-					label={ __( 'Title attribute' ) }
-					value={ title || '' }
-					onChange={ ( titleValue ) => {
-						setAttributes( { title: titleValue } );
-					} }
-					autoComplete="off"
-					help={ __(
-						'Additional information to help clarify the purpose of the link.'
-					) }
-				/>
-			</ToolsPanelItem>
-
 			<ToolsPanelItem
 				hasValue={ () => !! rel }
 				label={ __( 'Rel attribute' ) }
diff --git a/packages/block-library/src/navigation-link/index.php b/packages/block-library/src/navigation-link/index.php
@@ -249,10 +249,6 @@ function render_block_core_navigation_link( $attributes, $content, $block ) {
 		$html .= ' rel="nofollow"';
 	}
 
-	if ( isset( $attributes['title'] ) ) {
-		$html .= ' title="' . esc_attr( $attributes['title'] ) . '"';
-	}
-
 	// End appending HTML attributes to anchor tag.
 
 	// Start anchor tag content.
diff --git a/packages/block-library/src/navigation-link/transforms.js b/packages/block-library/src/navigation-link/transforms.js
@@ -115,13 +115,12 @@ const transforms = {
 		{
 			type: 'block',
 			blocks: [ 'core/buttons' ],
-			transform: ( { label, url, rel, title, opensInNewTab } ) => {
+			transform: ( { label, url, rel, opensInNewTab } ) => {
 				return createBlock( 'core/buttons', {}, [
 					createBlock( 'core/button', {
 						text: label,
 						url,
 						rel,
-						title,
 						linkTarget: opensInNewTab ? '_blank' : undefined,
 					} ),
 				] );
diff --git a/packages/block-library/src/navigation-link/update-attributes.js b/packages/block-library/src/navigation-link/update-attributes.js
@@ -19,7 +19,6 @@ import { safeDecodeURI } from '@wordpress/url';
  * @property {number}               [id]            A post or term id.
  * @property {boolean}              [opensInNewTab] Sets link target to _blank when true.
  * @property {string}               [url]           Link href.
- * @property {string}               [title]         Link title attribute.
  */
 /**
  * Link Control onChange handler that updates block attributes when a setting is changed.
diff --git a/packages/block-library/src/navigation-submenu/block.json b/packages/block-library/src/navigation-submenu/block.json
@@ -30,9 +30,6 @@
 		"url": {
 			"type": "string"
 		},
-		"title": {
-			"type": "string"
-		},
 		"kind": {
 			"type": "string"
 		},
diff --git a/packages/block-library/src/navigation-submenu/edit.js b/packages/block-library/src/navigation-submenu/edit.js
@@ -123,7 +123,6 @@ const useIsDraggingWithin = ( elementRef ) => {
  * @property {number}               [id]            A post or term id.
  * @property {boolean}              [opensInNewTab] Sets link target to _blank when true.
  * @property {string}               [url]           Link href.
- * @property {string}               [title]         Link title attribute.
  */
 
 export default function NavigationSubmenuEdit( {
@@ -135,7 +134,7 @@ export default function NavigationSubmenuEdit( {
 	context,
 	clientId,
 } ) {
-	const { label, url, description, rel, title } = attributes;
+	const { label, url, description, rel } = attributes;
 
 	const { showSubmenuIcon, maxNestingLevel, openSubmenusOnClick } = context;
 
@@ -392,7 +391,6 @@ export default function NavigationSubmenuEdit( {
 							label: '',
 							url: '',
 							description: '',
-							title: '',
 							rel: '',
 						} );
 					} }
@@ -458,27 +456,6 @@ export default function NavigationSubmenuEdit( {
 						/>
 					</ToolsPanelItem>
 
-					<ToolsPanelItem
-						label={ __( 'Title attribute' ) }
-						isShownByDefault
-						hasValue={ () => !! title }
-						onDeselect={ () => setAttributes( { title: '' } ) }
-					>
-						<TextControl
-							__nextHasNoMarginBottom
-							__next40pxDefaultSize
-							value={ title || '' }
-							onChange={ ( titleValue ) => {
-								setAttributes( { title: titleValue } );
-							} }
-							label={ __( 'Title attribute' ) }
-							autoComplete="off"
-							help={ __(
-								'Additional information to help clarify the purpose of the link.'
-							) }
-						/>
-					</ToolsPanelItem>
-
 					<ToolsPanelItem
 						label={ __( 'Rel attribute' ) }
 						isShownByDefault
diff --git a/packages/block-library/src/navigation-submenu/index.php b/packages/block-library/src/navigation-submenu/index.php
@@ -169,10 +169,6 @@ function render_block_core_navigation_submenu( $attributes, $content, $block ) {
 			$html .= ' rel="nofollow"';
 		}
 
-		if ( isset( $attributes['title'] ) ) {
-			$html .= ' title="' . esc_attr( $attributes['title'] ) . '"';
-		}
-
 		$html .= '>';
 		// End appending HTML attributes to anchor tag.
 

Original file line number	Diff line number	Diff line change
`@@ -249,10 +249,6 @@ function render_block_core_navigation_link( $attributes, $content, $block ) {`
`249`	`249`	`$html .= ' rel="nofollow"';`
`250`	`250`	`}`
`251`	`251`
`252`		`- if ( isset( $attributes['title'] ) ) {`
`253`		`- $html .= ' title="' . esc_attr( $attributes['title'] ) . '"';`
`254`		`- }`
`255`		`-`
`256`	`252`	`// End appending HTML attributes to anchor tag.`
`257`	`253`
`258`	`254`	`// Start anchor tag content.`
Original file line number	Diff line number	Diff line change
`@@ -169,10 +169,6 @@ function render_block_core_navigation_submenu( $attributes, $content, $block ) {`
`169`	`169`	`$html .= ' rel="nofollow"';`
`170`	`170`	`}`
`171`	`171`
`172`		`- if ( isset( $attributes['title'] ) ) {`
`173`		`- $html .= ' title="' . esc_attr( $attributes['title'] ) . '"';`
`174`		`- }`
`175`		`-`
`176`	`172`	`$html .= '>';`
`177`	`173`	`// End appending HTML attributes to anchor tag.`
`178`	`174`