CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 20:33:33 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/WordPress/gutenberg.git
etag: W/"b06163a12f1bc0b67360ab326df1c34e"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ZfzzMLF7zYiwJepYZYyU2oSbL7LSVMR6%2FYH2ErvQSgWUMRBr6mZSL3bOK6L7BwFR4KiHd9B1g%2F1u8ML4U3yeYMrEVGn2%2FHacOXhJpGScl%2BZly5rQnvWLaPEHFayA4vxlSy4oWaXs8rYq11dzCXjAVqc60WEfPTKGkU4Klu%2BhGvVjEtuX4M6VIxd5Q%2B%2FnmtTsJpTNjyGlhGZLg6TtLANh9MC%2BSzh0hjhtFiftcKr5WSIuAiieeRlJqAwaesCRzsF%2FLXhnVyTWprfJIutkbe4Z9w%3D%3D--2%2FmrYmpt64%2FQt0pd--XfA0OZiX0aX6DDxWNzss1g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.940177886.1760214813; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 20:33:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 20:33:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C644:3CB96D:9E4E81:D08ABC:68EABF1D
Navigation Link: surface page creation functionality clearly in the L… · WordPress/gutenberg@64be23c · GitHub



authored
Copy file name to clipboardExpand all lines: packages/block-library/src/navigation-link/editor.scss
Copy file name to clipboardExpand all lines: packages/block-library/src/navigation-link/link-ui.js
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Commit 64be23c

Navigation Link: surface page creation functionality clearly in the LinkUI (#71188)
* Add page creation functionality to Navigation Link UI
- Add LinkUIPageCreator component for creating new pages
- Integrate page creation as separate sub-view above Add Block button
- Replace built-in LinkControl createSuggestion with custom UI
- Add proper error handling and form validation
- Maintain existing permissions and accessibility patterns
- Add CSS styling for new page creator component
This is a PoC to test moving page creation out of search results
and into a dedicated interface below the link input.
* Refactor page creation flow to use proper WordPress data patterns
- Remove useEffect and manual state management
- Use data store selectors for tracking entity creation state
- Follow WordPress data-basics patterns for create forms
- Fix Rules of Hooks violations
- Clean up unused imports and improve code organization
* Simplify page creation flow by removing unnecessary hasFinishedSaving
- Remove redundant hasFinishedSaving selector
- Use only isSaving and lastError to determine when to look for new pages
- Cleaner and more straightforward logic flow
* Dramatically simplify page creation flow following data-basics documentation
- Remove complex hasResolved and entity resolution logic
- Use saveEntityRecord return value directly as shown in docs
- Eliminate unnecessary useSelect hooks and complex state tracking
- Follow exact pattern from WordPress data-basics tutorial
* Add throwOnError option to saveEntityRecord for proper error handling
- Add { throwOnError: true } to saveEntityRecord options
- This ensures await properly throws errors that can be caught
- Follows WordPress data-basics documentation pattern for error handling
* Fix page creator layout and add cancel button
- Add Cancel button alongside Create button for better UX
- Fix spacing between form elements (title, checkbox, help text, buttons)
- Improve button layout with proper spacing and right-alignment
- Add accessibleWhenDisabled to maintain accessibility
- Fix tight spacing that was making layout look broken
* Copy Add block UI back button pattern for page creator
- Use exact same Button props: size='small', no variant, no __next40pxDefaultSize
- Match CSS styling: margin-left and text-transform
- Remove absolute positioning that was hiding the button
- Remove unused VisuallyHidden import
- Back button now matches the working Add block UI exactly
* Fix page creator layout to match Add block UI exactly
- Use VStack/HStack with proper spacing (4) instead of custom CSS margins
- Match Add block UI CSS pattern: padding-top and margin-left only
- Remove custom form spacing and rely on WordPress component defaults
- Add required __nextHasNoMarginBottom props for proper component styling
- Remove unused imports and variables
- Form now has clean, consistent spacing matching the working Add block UI
* Navigation Link: Add page creation functionality to LinkUI
- Add dedicated 'Create Page' button in LinkUI for better discoverability
- Create PageCreator component with form for page creation
- Allow users to choose between draft and published page creation
- Restrict page creation to page variations and fresh navigation-link blocks
- Match LinkControl width constraints for consistent UI sizing
- Fix experimental component imports (VStack, HStack)
- Add proper error handling and loading states
* Navigation Link: Fix focus management in LinkUI back navigation
- Fix issue where both Add Page and Add Block buttons were getting focus
- Ensure only the correct button is focused when returning from sub-views
- Reset opposite focus flag when setting one to true in onBack handlers
- Maintains proper focus state for accessibility and user experience
* Navigation Link: Add automatic focus to PageCreator back button
- Add useFocusOnMount hook to PageCreator component for consistent behavior
- Ensure back button receives focus when PageCreator component mounts
- Match the focus behavior of LinkUIBlockInserter component
- Improves accessibility and user experience consistency
* Fix vertical scrollbar in Link UI
* Use better icon
* Update icon
* Fix issues introduced by rebase
Unlinked contributors: porg.
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>1 parent 3079855 commit 64be23cCopy full SHA for 64be23c
File tree
Expand file treeCollapse file tree
5 files changed
+254
-66
lines changedFilter options
- packages/block-library/src
- navigation-link
- navigation
Expand file treeCollapse file tree
5 files changed
+254
-66
lines changedCollapse file: packages/block-library/src/navigation-link/editor.scss
packages/block-library/src/navigation-link/editor.scss
Copy file name to clipboardExpand all lines: packages/block-library/src/navigation-link/editor.scss+17Lines changed: 17 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
122 | 122 |
| |
123 | 123 |
| |
124 | 124 |
| |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + |
Collapse file: packages/block-library/src/navigation-link/link-ui.js
packages/block-library/src/navigation-link/link-ui.js
Copy file name to clipboardExpand all lines: packages/block-library/src/navigation-link/link-ui.js+68-65Lines changed: 68 additions & 65 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
8 | 8 |
| |
9 | 9 |
| |
10 | 10 |
| |
11 |
| - | |
| 11 | + | |
12 | 12 |
| |
13 | 13 |
| |
14 | 14 |
| |
15 | 15 |
| |
16 | 16 |
| |
17 | 17 |
| |
18 | 18 |
| |
19 |
| - | |
20 | 19 |
| |
21 | 20 |
| |
22 | 21 |
| |
23 | 22 |
| |
24 | 23 |
| |
25 | 24 |
| |
26 |
| - | |
27 |
| - | |
28 |
| - | |
29 |
| - | |
30 |
| - | |
31 |
| - | |
| 25 | + | |
| 26 | + | |
32 | 27 |
| |
33 | 28 |
| |
34 | 29 |
| |
35 | 30 |
| |
36 | 31 |
| |
37 | 32 |
| |
38 | 33 |
| |
| 34 | + | |
39 | 35 |
| |
40 | 36 |
| |
41 | 37 |
| |
| |||
151 | 147 |
| |
152 | 148 |
| |
153 | 149 |
| |
| 150 | + | |
154 | 151 |
| |
155 |
| - | |
| 152 | + | |
156 | 153 |
| |
157 | 154 |
| |
158 | 155 |
| |
159 | 156 |
| |
160 | 157 |
| |
161 |
| - | |
162 |
| - | |
163 |
| - | |
164 |
| - | |
165 |
| - | |
166 |
| - | |
167 |
| - | |
168 |
| - | |
169 |
| - | |
170 |
| - | |
171 |
| - | |
172 |
| - | |
173 |
| - | |
174 |
| - | |
175 |
| - | |
176 |
| - | |
177 |
| - | |
178 |
| - | |
179 |
| - | |
180 |
| - | |
181 |
| - | |
182 |
| - | |
183 |
| - | |
184 |
| - | |
185 |
| - | |
186 |
| - | |
187 |
| - | |
188 |
| - | |
189 |
| - | |
190 | 158 |
| |
191 | 159 |
| |
192 | 160 |
| |
| |||
198 | 166 |
| |
199 | 167 |
| |
200 | 168 |
| |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
201 | 176 |
| |
202 | 177 |
| |
203 | 178 |
| |
| |||
207 | 182 |
| |
208 | 183 |
| |
209 | 184 |
| |
| 185 | + | |
| 186 | + | |
| 187 | + | |
210 | 188 |
| |
211 | 189 |
| |
212 | 190 |
| |
| |||
215 | 193 |
| |
216 | 194 |
| |
217 | 195 |
| |
218 |
| - | |
| 196 | + | |
219 | 197 |
| |
220 | 198 |
| |
221 | 199 |
| |
| |||
235 | 213 |
| |
236 | 214 |
| |
237 | 215 |
| |
238 |
| - | |
239 |
| - | |
240 |
| - | |
241 |
| - | |
242 |
| - | |
243 |
| - | |
244 |
| - | |
245 |
| - | |
246 |
| - | |
247 |
| - | |
248 |
| - | |
249 |
| - | |
250 |
| - | |
251 |
| - | |
252 |
| - | |
253 |
| - | |
254 |
| - | |
255 |
| - | |
256 |
| - | |
257 |
| - | |
258 |
| - | |
259 |
| - | |
260 |
| - | |
261 |
| - | |
| 216 | + | |
262 | 217 |
| |
263 | 218 |
| |
264 | 219 |
| |
| |||
270 | 225 |
| |
271 | 226 |
| |
272 | 227 |
| |
| 228 | + | |
273 | 229 |
| |
274 | 230 |
| |
275 | 231 |
| |
276 | 232 |
| |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
277 | 238 |
| |
278 | 239 |
| |
279 | 240 |
| |
| |||
287 | 248 |
| |
288 | 249 |
| |
289 | 250 |
| |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
290 | 263 |
| |
| 264 | + | |
| 265 | + | |
291 | 266 |
| |
292 | 267 |
| |
293 | 268 |
| |
| |||
296 | 271 |
| |
297 | 272 |
| |
298 | 273 |
| |
299 |
| - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
300 | 281 |
| |
301 | 282 |
| |
| 283 | + | |
302 | 284 |
| |
303 | 285 |
| |
304 | 286 |
| |
| |||
307 | 289 |
| |
308 | 290 |
| |
309 | 291 |
| |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
310 | 299 |
| |
311 |
| - | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
312 | 315 |
| |
313 | 316 |
| |
314 | 317 |
| |
|
You can’t perform that action at this time.
0 commit comments