Do not throw UnsupportedOperationException when httpRequest.getSession(false) is called #1305

evernat · 2016-10-15T23:18:07Z

When httpRequest.getSession(false) is called, the callers does not ask to create a http session.
(javadoc of HttpServletRequest: "If create is false and the request has no valid HttpSession, this method returns null.")

So throwing UnsupportedOperationException is not needed in this case and returning null is enough.

This will fix a blocking issue in the Sonar JavaMelody plugin.

…n(false) is called When httpRequest.getSession(false) is called, the callers does not ask to create a http session. (javadoc of HttpServletRequest: "If create is false and the request has no valid HttpSession, this method returns null.") So throwing UnsupportedOperationException is not needed in this case and returning null is enough. This will fix a [blocking issue](javamelody/sonar-javamelody#4) in the [Sonar JavaMelody plugin](https://github.com/javamelody/javamelody/wiki/UserGuide#sonar-plugin).

julienlancelot · 2016-10-17T07:28:01Z

@evernat Why do the Sonar JavaMeledoy plugin needs to get a HTTP session ?
As Sonarqube is not allowing usage of HTTP session, it's a bad practice to not throw an exception.

evernat · 2016-10-17T07:39:50Z

@julienlancelot
No, Sonar JavaMelody plugin does not need to get a HTTP session.
In fact, the plugin calls httpRequest.getSession(false) to see if there is a session and if there is no session then no problem.
So the plugin does not need Sonarqube to allow usage of HTTP session, but the plugin needs that Sonarqube says there is no session.
The PR will not change the fact that Sonarqube refuses to create HTTP sessions. The PR will just do the right thing, according to the servlet api, for httpRequest.getSession(create) when create is false.

julienlancelot · 2016-10-19T09:59:04Z

Thanks @evernat, this PR has been merged !

evernat mentioned this pull request Oct 15, 2016

error starting plugin at sonar 6.1:alpine javamelody/sonar-javamelody#4

Closed

julienlancelot self-assigned this Oct 19, 2016

julienlancelot merged commit 836937c into SonarSource:master Oct 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not throw UnsupportedOperationException when httpRequest.getSession(false) is called #1305

Do not throw UnsupportedOperationException when httpRequest.getSession(false) is called #1305

Uh oh!

evernat commented Oct 15, 2016

Uh oh!

julienlancelot commented Oct 17, 2016

Uh oh!

evernat commented Oct 17, 2016 •

edited

Loading

Uh oh!

julienlancelot commented Oct 19, 2016

Uh oh!

Uh oh!

Do not throw UnsupportedOperationException when httpRequest.getSession(false) is called #1305

Do not throw UnsupportedOperationException when httpRequest.getSession(false) is called #1305

Uh oh!

Conversation

evernat commented Oct 15, 2016

Uh oh!

julienlancelot commented Oct 17, 2016

Uh oh!

evernat commented Oct 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julienlancelot commented Oct 19, 2016

Uh oh!

Uh oh!

evernat commented Oct 17, 2016 •

edited

Loading