You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, data is converted in the form of html table. I have shifted it to javascript array for the further server-side implementation (as datatable can take Array of Array). I will execute the server-side implementation (to load large set of data piece by piece) in this PR too. Parallel changes will be done accordingly in daru-datable in a separate PR.
I am also trying to resolve this issue. In this PR data is set correctly in the javascript array but the column names are overlapping for multiple tables.
This PR runs in parallel with changes in daru-data_tables#20. Those changes are not reflected here and will be seen after that PR gets merged. So some of the test cases failed due to that.
Fixes issue daru-data_tables#19. Now, datatable is working fine with javascript array as:
I haven't added tests for generate_html as generate_html and export_html_file will then have the redundant tests. I am adding the tests for to_html in daru-data_tables.
Prakriti-nith
changed the title
[WIP] Use javascript Array rather than html table in DataTables
Use javascript Array rather than html table in DataTables
Jul 14, 2018
I haven't added tests for generate_html as generate_html and export_html_file will then have the redundant tests. I am adding the tests for to_html in daru-data_tables.
We should have testcases calling datatables adaptor here as well.
In this PR, I have updated the API, added docs and tests and added export_html and generate_html methods.
Below are the screenshots of the examples:
Prakriti-nith
changed the title
Use javascript Array rather than html table in DataTables
Updated API, added tests, docs, export_html method and generate_html method
Jul 22, 2018
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, data is converted in the form of html table. I have shifted it to javascript array for the further server-side implementation (as datatable can take Array of Array). I will execute the server-side implementation (to load large set of data piece by piece) in this PR too. Parallel changes will be done accordingly in daru-datable in a separate PR.
I am also trying to resolve this issue. In this PR data is set correctly in the javascript array but the column names are overlapping for multiple tables.