Merge pull request #73 from Prakriti-nith/rubocop

Shekharrajak · web-flow · commit 86455e7dc7a2 · 2018-02-17T12:08:29.000+05:30
Enabled RuboCop MethodLength in encapsulate_js_iruby method
diff --git a/lib/daru/view/adapters/highcharts/layout_helper_iruby.rb b/lib/daru/view/adapters/highcharts/layout_helper_iruby.rb
@@ -22,41 +22,53 @@ def build_html_output_iruby(type, placeholder, object, &block)
       encapsulate_js_iruby core_js
     end
 
-    # rubocop:disable Metrics/PerceivedComplexity, Metrics/MethodLength
+    # rubocop:disable Metrics/PerceivedComplexity
     def encapsulate_js_iruby(core_js)
       js_output =
         if request_is_xhr?
           "#{js_start_iruby} #{core_js} #{js_end_iruby}"
         # Turbolinks.version < 5
         elsif defined?(Turbolinks) && request_is_referrer?
-          <<-EOJS
-          #{js_start_iruby}
-            var f = function(){
-              document.removeEventListener('page:load', f, true);
-              #{core_js}
-            };
-            document.addEventListener('page:load', f, true);
-          #{js_end_iruby}
-          EOJS
+          to_s(eventlistener_page_load)
         elsif defined?(Turbolinks) && request_turbolinks_5_tureferrer?
-          <<-EOJS
-          #{js_start_iruby}
-            document.addEventListener("turbolinks:load", function() {
-              #{core_js}
-            });
-          #{js_end_iruby}
-          EOJS
+          to_s(eventlistener_turbolinks_load)
         else
-          <<-EOJS
-          #{js_start_iruby}
-            #{core_js}
-          #{js_end_iruby}
-          EOJS
+          to_s(call_core_js)
         end
 
       defined?(raw) ? raw(js_output) : js_output
     end
-    # rubocop:enable Metrics/PerceivedComplexity, Metrics/MethodLength
+    # rubocop:enable Metrics/PerceivedComplexity
+
+    def eventlistener_page_load
+      <<-EOJS
+      #{js_start_iruby}
+        var f = function(){
+          document.removeEventListener('page:load', f, true);
+          #{core_js}
+        };
+        document.addEventListener('page:load', f, true);
+      #{js_end_iruby}
+      EOJS
+    end
+
+    def eventlistener_turbolinks_load
+      <<-EOJS
+      #{js_start_iruby}
+        document.addEventListener("turbolinks:load", function() {
+          #{core_js}
+        });
+      #{js_end_iruby}
+      EOJS
+    end
+
+    def call_core_js
+      <<-EOJS
+      #{js_start_iruby}
+        #{core_js}
+      #{js_end_iruby}
+      EOJS
+    end
 
     def js_start_iruby
       <<-EOJS
