| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 02:10:53 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=283.184152,conversation_content-fragment;desc="conversation_content fragment";dur=718.396327,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=334.666889,nginx;desc="NGINX";dur=0.811136,glb;desc="GLB";dur=100.628218
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=MOQrXFA4s2m8%2Fi9WRt%2Fi9sCHkqCNIC%2BzWhLsCgbTE%2F3LOwGXFx%2Fu8qpJMT7ok8YZ9rhJaM44bvSmKHC9v%2FktzcAUaMTF134Mnck5sUNuWUKjhmF72Qx%2BOstaU3oNasOuQHIXjNbzQqznbuGZSoWyxwCszOOAZXyQJFMraiK5sLwI984FSV4uN90qqV5VoO4EJBJpZFEiQKtQ5Piy0hstl%2Fln4FZTsOM11Vx2sUxxQ%2FeURqK6S%2FgRc9%2FSUib5zj7tYT5MDg2tngGsOvIUXCAX5Q%3D%3D--fjtovUTANNyS5Tuu--oQXH0NDGY6zqVQ%2B0w5VV2w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.143129124.1753495852; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:10:52 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:10:52 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A7AC:7565A:B86D5:121272:6884392C
Feature: Support UIKit for macOS (Catalyst) by dreampiggy · Pull Request #2808 · SDWebImage/SDWebImage · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Feature: Support UIKit for macOS (Catalyst) #2808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dreampiggy
merged 14 commits into
SDWebImage:master
from
dreampiggy:project_uikit_macos
Aug 19, 2019
Merged
Feature: Support UIKit for macOS (Catalyst) #2808
dreampiggy
merged 14 commits into
SDWebImage:master
from
dreampiggy:project_uikit_macos
Aug 19, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Xcode 11 Beta5 's runtime behavior of UIKit for macOS
…ode New Build System issue of implicit dependency for `SDWebImage.framework` (Both CocoaPosd and SDWebImage.xcodeproj can produce this framework), which cause build issue
…s not have macOS 10.15 env yet.
Codecov Report
@@ Coverage Diff @@
## master #2808 +/- ##
==========================================
- Coverage 84.06% 84.03% -0.03%
==========================================
Files 57 57
Lines 6349 6351 +2
==========================================
Hits 5337 5337
- Misses 1012 1014 +2
Continue to review full report at Codecov.
|
kinarobin
approved these changes
Aug 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with maccatalyst support!
…avoid Xcode's default path conflict) and cleanup the code structure
dreampiggy
commented
Aug 19, 2019
| SUPPORTS_MACCATALYST = YES | ||
|
|
||
| // macOS Catalyst support | ||
| DERIVE_MACCATALYST_PRODUCT_BUNDLE_IDENTIFIER = NO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is meaningless for framework, only for the Application. So we set it to NO (The Xcode 11 default value for framework)
Mac Catalyst App must not have the same bundle ID as iOS App. So this is import for Application to assign the different bundle ID. This options YES will add a maccatalyst prefix to the bundleID, which make the automatically sign works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: #2743
Pull Request Description
This PR including all the things related to SDWebImage and macOS Catalyst supoort