You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First in a series of PRs to catch up fundamental-styles. The primary changes in this set that are relevant to fundamental-react (up to 0.3.0) were markup changes to the Menu and Shellbar ProductSwitch components.
Menu
separator prop and <hr> removed from MenuItem
separated prop added to MenuList
addonBefore prop passed down into MenuItem in order to render addon span
addon node changed to span and is now wrapped within the a
Shellbar
ProductSwitcher renamed to ProductSwitch
Import ProductSwitch css file
Removed nav node from ProductSwitch
Updated classnames in ProductSwitch
Use glyph in ProductList instead of images
Known issues
ProductSwitch button in Shellbar has a white background. Further PRs to catch up on Button classname changes will fix the issue.
A new component was added which is out of scope for this PR. Issue #821 has already been created for the new Notification component.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[BREAKING CHANGE]
First in a series of PRs to catch up fundamental-styles. The primary changes in this set that are relevant to fundamental-react (up to 0.3.0) were markup changes to the Menu and Shellbar ProductSwitch components.
separator
prop and<hr>
removed fromMenuItem
separated
prop added toMenuList
addonBefore
prop passed down intoMenuItem
in order to renderaddon
spanaddon
node changed tospan
and is now wrapped within thea
ProductSwitcher
renamed toProductSwitch
ProductSwitch
css filenav
node fromProductSwitch
ProductSwitch
ProductList
instead of imagesKnown issues
ProductSwitch
button inShellbar
has a white background. Further PRs to catch up onButton
classname changes will fix the issue.A new component was added which is out of scope for this PR. Issue #821 has already been created for the new Notification component.
https://github.com/SAP/fundamental-styles/blob/master/CHANGELOG.md
Two more PRs are planned to bring it up to 0.3.1 and then 0.4.0-rc.3 to unblock calendar a11y work.