You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DorinR edited this page May 27, 2019
·
8 revisions
Contributing
Thank you for considering contributing to SAP Fiori Fundamentals. It's people like you that make this such a great tool.
Did you find a bug?
If you've noticed a bug or have a question, search the issue tracker to see if
someone else in the community has already created a ticket. If not, go ahead and
open a new issue! Be sure to include a title and clear
description, as much relevant information as possible, and a code sample
or an executable test case demonstrating the expected behavior that is not
occurring. See Reporting an Issue.
Fork & create a branch
If this is something you think you can fix, then fork Fundamentals and
create a branch with a descriptive name.
A good branch name would be (where issue #325 is the ticket you're working on):
git checkout -b feature/325-japanese-translation
Implement your fix or feature
At this point, you're ready to make your changes! Feel free to ask for help, everyone is a beginner at first 😸
Develop component template and SASS as a standalone component. For new components, see Creating a New Component
Test in multiple browsers with no CSS dependencies and with common libs like Bootstrap
Run the test framework/playground
Any markup or CSS changes should begin the test framework. The component test framework loads only core.scss and individual component .scss files. The HTML created here will be used on the documentation site.
In the subject of the pull request, use feat: to denote an enhancement, fix: to denote a bug fix, chore: for small configuration updates or docs: for documentation updates and briefly describe the bug fix or enhancement you are contributing.
Assign the Review as SAP/fundamental-styles.
Merging a PR (maintainers only)
A PR can only be merged into master by a maintainer if has passed all required status checks.