CARVIEW |
Select Language
HTTP/2 200
date: Mon, 21 Jul 2025 05:13:08 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=287.147998,conversation_content-fragment;desc="conversation_content fragment";dur=470.77118,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=186.897319,nginx;desc="NGINX";dur=1.174591,glb;desc="GLB";dur=95.926549
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pjHwhnHfXrBnYs0nuQ8pDtBUEK4fRvHWSdHZtF6QxSw9u%2B%2B1GxaX%2FH%2FRNIK13AeG3lmZO4%2FeHQxCU%2BHVvpa38k%2FdDUNygclNqfBTzKjUOcmfKTwDeyBOw4diFQEJ3mYeNmHXaiGRsju2ftO94x2fASaczwM%2F1EEfF%2B8MBXS90uUAnkd4XuJDl2WqURtiZ8N1kuSfa7Plo7pSvdedbCoHZEz6dnfi8gGEHhWzEzP6lpvFhNXKzHJBzrkhvOehJvph919irJB1Mf0iITLeC728%2FA%3D%3D--bKCvs6iEv05p9KMs--J7Y9QBrX4fD5EdJiAG9GRg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.295378507.1753074787; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 05:13:07 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 21 Jul 2026 05:13:07 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BE22:1A6C04:1645C89:1D2BD39:687DCC63
3.x: Add eager truncation to bounded replay() to avoid item retention by akarnokd · Pull Request #6532 · ReactiveX/RxJava · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
3.x: Add eager truncation to bounded replay() to avoid item retention #6532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
akarnokd
merged 2 commits into
ReactiveX:3.x
from
akarnokd:ReplayBufferHeadRetentionFix
Jun 24, 2019
Merged
3.x: Add eager truncation to bounded replay() to avoid item retention #6532
akarnokd
merged 2 commits into
ReactiveX:3.x
from
akarnokd:ReplayBufferHeadRetentionFix
Jun 24, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #6532 +/- ##
============================================
- Coverage 98.26% 98.26% -0.01%
- Complexity 6185 6199 +14
============================================
Files 680 680
Lines 44883 44954 +71
Branches 6193 6197 +4
============================================
+ Hits 44106 44175 +69
+ Misses 247 244 -3
- Partials 530 535 +5
Continue to review full report at Codecov.
|
70 tasks
This was referenced Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR adds the
eagerTruncate
option to thereplay
operator so that thehead
node will lose the item reference it holds upon truncation.The bounded buffers in
replay
implement a linked list that when truncated, moves the head reference forward along the links atomically. This allows late consumers to pick up the head and follow the links between them to get items replayed. However, the truncation may happen concurrently with a consumer working on some prior nodes so if the truncation wouldnull
out the value, the consumer reaching the same node would seenull
as well and fail.To avoid this type of retention, the head node has to be refreshed with a new node still pointing to the next node in the chain but without any value.
The reason this is not the default is that it requires an additional allocation for each new incoming value when the buffer is full, which would reduce performance in cases where the excess retention is not a problem.
Overloads to both the direct and function-variants of both
Flowable.replay()
andObservable.replay()
have been added. To avoid too many overloads, only one extra overload has been added extending the signature of the longest parameterized method per each bounds mode (size, time, time+size).Their unit test files have been cloned so that both the non-eager (original) behavior and the eager behavior is tested separately.
Fixes #6475