CARVIEW |
Select Language
HTTP/2 200
date: Thu, 31 Jul 2025 02:31:46 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=279.211614,conversation_content-fragment;desc="conversation_content fragment";dur=309.963488,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=256.405711,nginx;desc="NGINX";dur=0.931936,glb;desc="GLB";dur=101.208998
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=kTC0GqVtwePkkeKE%2BFZNjHNSB1ABP4Ah5OlNIq5%2FTIQ%2FKkWo3TpNfOIBbDVc89l%2B8ZMstmPdLEmaipA439KTyRUhlTtT116znOxQEHTi9BwhwcX9YZOsUHY3hll2Jz%2BfLRhs%2F2kCCVpP2saRdecjJ%2BHCo2hPWWdsVgVcavpHJp9l%2BOzP7A7iZbx5oT0qfKaw9OXbwWQp%2BkQUfJuEbgnNSVOB8Er7lB4nyvHpQZP44dlQd%2BBU5nOaTVKmCC83%2Fi3FzUcY2aD%2FPxVA1Eelg3IShQ%3D%3D--PiUts0vJj2IGT%2BYF--D4s4%2BXSEeDY9N722NH9wKg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1296105233.1753929106; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 02:31:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 02:31:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 90EE:21A23A:178D34:234A77:688AD592
Enable USE_QUADMATH builds on Windows by sisyphus · Pull Request #18465 · Perl/perl5 · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 587
Enable USE_QUADMATH builds on Windows #18465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align __float128 when using 64-bit mingw compilers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR enables building of perl with USE_QUADMATH on MS Windows using (32-bit and 64-bit) mingw-w64 ports of gcc.
Unforunately, having it smoked is probably not going to prove much, and the same can be said of the CI testing that I expect this PR to initiate.
AFAIK there are currently no smokers set up to attempt a USE_QUADMATH build on Windows - the best that can be shown by smoking it is that these changes haven't broken pre-existing functionality.
I've run extensive testing locally which has established (to my satisfaction, at least) that no such "pre-existing functionality" has been altered.
Furthermore, that same extensive testing has shown that the USE_QUADMATH builds themselves are fine.
With both 'gmake' and 'dmake', I have built (with the files contained in this PR) the following configurations of perl:
MSWin32-x86-multi-thread
MSWin32-x86-multi-thread-ld
MSWin32-x86-multi-thread-quadmath
MSWin32-x86-multi-thread-64int
MSWin32-x86-multi-thread-64int-ld
MSWin32-x86-multi-thread-64int-quadmath
MSWin32-x64-multi-thread
MSWin32-x64-multi-thread-ld
MSWin32-x64-multi-thread-quadmath
For each of those (9 x 2 == 18) builds I ran (n|g)make, (n|g)make test, (n|g)make install, and (n|g)make distclean.
Everything was fine, except for the following caveat that applies only to the "MSWin32-x86-multi-thread-quadmath" configuration:
For this build (with both 'gmake' and 'dmake'), I get some Math::BigInt/BigFloat test failures. Those test failures are identical for both flavours of make.
I don't think this should be considered to be a blocker.
Firstly, it's not breaking any existing builds.
Secondly, this configuration has ivsize=4 and nvtype of __float128, which is a very rare configuration. (I doubt that there are any smokers for any system that test such a configuration. Right ?)
I don't see it as a configuration that will be highly favoured. (Far more likely that a selection of ivsize==8 will be desired when nvtype is set to __float128.)
Of course, I'll investigate this strange issue anyway - with an aim to fixing it with a separate PR, after this one has been merged into blead.
Cheers,
Rob