You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously POSIX::signbit() had a fallback implementation for the case Perl_signbit is not defined, but this code is apparently broken because it returns wrongly non-zero (true) value for signbit(+0.0).
Currently Perl_signbit is always defined (either as a macro or as a function), so it seems to be better to use it unconditionally.
Additionally, unused macro c99_signbit is deleted, which is also apparently broken because there is no signbitl() in C99.
Previously POSIX::signbit() had a fallback implementation for the case
Perl_signbit is not defined, but this is apparently broken
because it returns wrongly non-zero (true) value for signbit(+0.0).
Currently Perl_signbit is always defined (either as a macro or as
a function), so it can be used unconditionally.
Additionally, unused macro c99_signbit is deleted, which is also
apparently broken because there is no signbitl() in C99.
jkeenan
changed the title
Use Perl_signbit uncoditionally for POSIX::signbit()
Use Perl_signbit unconditionally for POSIX::signbit()
Dec 27, 2020
Previously POSIX::signbit() had a fallback implementation for the case Perl_signbit is not defined, but this code is apparently broken because it returns wrongly non-zero (true) value for signbit(+0.0).
Currently Perl_signbit is always defined (either as a macro or as a function), so it seems to be better to use it unconditionally.
Additionally, unused macro c99_signbit is deleted, which is also apparently broken because there is no signbitl() in C99.
Can you specify more precisely what you mean by previously and currently?
Previously POSIX::signbit() had a fallback implementation for the case Perl_signbit is not defined, but this code is apparently broken because it returns wrongly non-zero (true) value for signbit(+0.0).
Currently Perl_signbit is always defined (either as a macro or as a function), so it seems to be better to use it unconditionally.
Additionally, unused macro c99_signbit is deleted, which is also apparently broken because there is no signbitl() in C99.
@khwilliamson, @doughera88 You have worked on what appears to be a relevant section of numeric.c. Could you take a look at this p.r.?
Previously POSIX::signbit() had a fallback implementation for the case Perl_signbit is not defined, but this code is apparently broken because it returns wrongly non-zero (true) value for signbit(+0.0).
Currently Perl_signbit is always defined (either as a macro or as a function), so it seems to be better to use it unconditionally.
Additionally, unused macro c99_signbit is deleted, which is also apparently broken because there is no signbitl() in C99.
Can you specify more precisely what you mean by previously and currently?
Sorry for my lack of explanation. These are based on this commit (c934219, which is based on blead's dba7cf2); I mean "before c934219" by previously and "as of c934219" by currently.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
POSIX::signbit()
had a fallback implementation for the casePerl_signbit
is not defined, but this code is apparently broken because it returns wrongly non-zero (true) value forsignbit(+0.0)
.Currently
Perl_signbit
is always defined (either as a macro or as a function), so it seems to be better to use it unconditionally.Additionally, unused macro
c99_signbit
is deleted, which is also apparently broken because there is nosignbitl()
in C99.