CARVIEW |
Select Language
HTTP/2 302
date: Thu, 31 Jul 2025 02:31:04 GMT
content-length: 0
location: https://github.com/Perl/perl5/pull/22724
server-timing: nginx;desc="NGINX";dur=0.874298,glb;desc="GLB";dur=101.478402
x-voltron-version: 321f992
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=fLDKEERRXd6FdxyjEyJjOZnOvPUFxg5WyU3UPHmPC8WjMeS9EBAfiRRnnQN4iLPzyTawPKhCKaqaK2ypVgVFH6G9GaZR5nFooYq7Cfcg2V7uGqPIAom0sXHQNe972tG1hLDgVCey7usKacG%2B7vqcJhJ5u6Z8P3g1nwfkwilumH3AG9EvidktcAYrsMnOS1tNBBmBKPSvVfS%2BTvu2K%2BZN2HFKP%2BByulB31idbkdREJojl%2FVC1EcIzH52jIWtV4%2Bax3eA5ReizUEX5jsEMfqjLnA%3D%3D--DXEaAPbbsDEEe8SB--1%2Btl1QRBNYXP%2BVL0RCgArQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1357487738.1753929064; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 02:31:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 31 Jul 2026 02:31:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8FFA:1892F4:179540:234D6C:688AD568
HTTP/2 200
date: Thu, 31 Jul 2025 02:31:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=301.279675,conversation_content-fragment;desc="conversation_content fragment";dur=337.007379,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=269.771507,nginx;desc="NGINX";dur=0.673163,glb;desc="GLB";dur=100.779166
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 8FFA:1892F4:179575:234DA9:688AD568
cygwin.c: fix several silly/terrible C errors by mauke · Pull Request #22724 · Perl/perl5 · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 587
cygwin.c: fix several silly/terrible C errors #22724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+15
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors fixed: Not detected by the compiler, but the preprocessor version checks only looked at `CYGWIN_VERSION_API_MINOR`, ignoring `CYGWIN_VERSION_API_MAJOR`. cygwin.c: In function 'utf8_to_wide_extra_len': cygwin.c:187:18: warning: initialization of 'size_t' {aka 'long unsigned int'} from 'size_t *' {aka 'long unsigned int *'} makes integer from pointer without a cast [-Wint-conversion] 187 | Size_t len = strlen(buf) + extra_len + 1; | ^~~~~~ `extra_len` was declared as a pointer, but used as an integer. I don't see how this could have ever worked. cygwin.c: In function 'S_convert_path_common': cygwin.c:339:38: warning: 'realloc' called on unallocated object 'wconverted' [-Wfree-nonheap-object] 339 | wconverted = (wchar_t *) realloc(&wconverted, newlen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ cygwin.c:357:39: warning: 'realloc' called on unallocated object 'converted_path' [-Wfree-nonheap-object] 357 | converted_path = (char *) realloc(&converted_path, newlen); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Again, I don't see how this could have ever worked. We're passing the address of a local (stack) variable to `realloc` (instead of the value of the variable). cygwin.c: In function 'wide_to_utf8': cygwin.c:173:32: warning: pointer targets in passing argument 3 of 'Perl_utf16_to_utf8_base' differ in signedness [-Wpointer-sign] 173 | utf16_to_utf8((U8 *) wsrc, buf, wlen, &blen); | ^~~ | | | char * The argument is declared as `U8 *`, so this is mostly harmless, but a cast silences the warning anyway. cygwin.c: In function 'utf8_to_wide_extra_len': cygwin.c:194:19: warning: passing argument 2 of 'Perl_utf8_to_utf16_base' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 194 | utf8_to_utf16(buf, (U8 *) wsrc, len, &wlen); | ^~~ This is arguably a bug in `utf8_to_utf16`, which doesn't declare its input argument as pointer-to-const. But it's also a `char *` vs `U8 *` type mismatch, so a cast silences both issues. cygwin.c: In function 'S_convert_path_common': cygwin.c:292:22: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 292 | char *name = (direction == to_posix) | ^ This is a missing `const` in the declaration of a variable that points to string literals.
tonycoz
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Errors fixed:
Not detected by the compiler, but the preprocessor version checks only looked at
CYGWIN_VERSION_API_MINOR
, ignoringCYGWIN_VERSION_API_MAJOR
.extra_len
was declared as a pointer, but used as an integer. I don't see how this could have ever worked.Again, I don't see how this could have ever worked. We're passing the address of a local (stack) variable to
realloc
(instead of the value of the variable).The argument is declared as
U8 *
, so this is mostly harmless, but a cast silences the warning anyway.This is arguably a bug in
utf8_to_utf16
, which doesn't declare its input argument as pointer-to-const. But it's also achar *
vsU8 *
type mismatch, so a cast silences both issues.This is a missing
const
in the declaration of a variable that points to string literals.