CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 18:38:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=466.75648,conversation_content-fragment;desc="conversation_content fragment";dur=625.513375,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=352.960148,nginx;desc="NGINX";dur=1.093328,glb;desc="GLB";dur=100.869276
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=8iyr7DA1Ak6H6Aqfw7nXcEDaMnOxWLmpTTB40cP%2BLutrlZFHCvwwQStuf9zfX9HJMzZHTfgi61Rs9yWCSrjUzq4skfmbg7qlax5a4I4bNR%2BSMIINfzm7fMaN2hdzl2qOKdMkT0GOWn%2B5qvmYfqmY8T4yAl76Gf%2FvAFYUdRQqFUaHRB27hfdsuREjaT7bQo53OBZnvPCFq57o5JxhpuF1czCB%2FqFGUG9ZAG3Uro%2FbSmD79S4M1WL%2Bfv5JzAVBDGFpJ4cJr8x%2BY76c1rRFOvX1OQ%3D%3D--rd2KEyc4KHwkKbmQ--CpQnTUCMAxcqKwXYilZfoA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1027444144.1753295893; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 18:38:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 18:38:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8CF0:3F8A98:15B37:1B12D:68812C15
[SOT] Explicit access layer attribute from `_parameters`/`_sub_layers`/`_buffers` to avoid `__getattr__` overhead and move dataclass utilities to `utils.py` by SigureMo · Pull Request #73469 · PaddlePaddle/Paddle · GitHub
[SOT] Explicit access layer attribute from
SigureMo
changed the title
[SOT] Explicit access layer attribute from
[SOT] Explicit access layer attribute from Jun 19, 2025
SigureMo
changed the title
[SOT] Explicit access layer attribute from
[SOT][3.13] Explicit access layer attribute from Jun 19, 2025
SigureMo
changed the title
[SOT][3.13] Explicit access layer attribute from
[SOT] Explicit access layer attribute from Jun 20, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] Explicit access layer attribute from _parameters
/_sub_layers
/_buffers
to avoid __getattr__
overhead and move dataclass utilities to utils.py
#73469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 2 commits into
PaddlePaddle:develop
from
cattidea:sot/explicit-access-layer-attribute-from-dict
Jun 20, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`/`_buffers` to avoid `__getattr__` overhead
你的PR提交成功,感谢你对开源项目的贡献! |
_parameters
/_sub_layers
/_buffers
to avoid __getattr__
overhead_parameters
/_sub_layers
/_buffers
to avoid __getattr__
overhead and move dataclass utilities to utils.py
_parameters
/_sub_layers
/_buffers
to avoid __getattr__
overhead and move dataclass utilities to utils.py
_parameters
/_sub_layers
/_buffers
to avoid __getattr__
overhead and move dataclass utilities to utils.py
gouzil
approved these changes
Jun 20, 2025
_parameters
/_sub_layers
/_buffers
to avoid __getattr__
overhead and move dataclass utilities to utils.py
_parameters
/_sub_layers
/_buffers
to avoid __getattr__
overhead and move dataclass utilities to utils.py
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Performance
Description
SOT 目前对于 layer 的参数/sublayer 的加载是直接走的
layer.weight
的这种方式,这样是会走Layer.__getattr__
的 dispatch 的,因为layer.weight
实际上会存在layer._parameters["weight"]
上,因为不在layer.__dict__
里,所以一定会 dispatch,但我们完全可以生成layer._parameters["weight"]
这样的加载方式,以消除掉__getattr__
的开销,这是通过构建 tracker 的方式实现的(同理,guard 开销也会降低)经过测试,
layer._parameters["weight"]
会比layer.weight
快 10 多倍,这对 guard 开销和加载参数开销都会有大幅降低当然,我们后面也可以在
VariableBase
上直接实现__getattr__
的 inline call,以避免每次都要重新实现类似逻辑,现在的实现是不够通用的另外顺带优化了下
dataclass
的 utilities