| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 11:01:53 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=370.922791,conversation_content-fragment;desc="conversation_content fragment";dur=464.073208,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=345.524597,nginx;desc="NGINX";dur=1.554337,glb;desc="GLB";dur=100.752455
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=GfIoBA1Og%2FG5nREGwuwjGAcm4ZVLovQdfAazxq63Tls5HmIJpSrMqI4GMrRezfkl10PN1fNmOQrtp2Z8C3TkVm0IS21EU16gS1NFqe6wd2VXzBMB%2B9yeKMJnpojX%2FzSoFRIk0eroq%2BrMOkGFNyQw30VhSo976RABJ2KltYw5%2BPnACSLfPtHgkbyp%2FswXIJxVhWSQy%2BT%2FPFALMTv7Cngn%2FcVN7iSoliZE8yUo78fUH%2B8aoNNPhlpeYuNTbG%2FIoa8AI4nJwxQ4tYu5HnfrOZ%2FtPw%3D%3D--axI2S6XmDQDE8sNu--v8BqU4tyPXdsknfsx1Ysww%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1840088120.1753268513; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 11:01:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 11:01:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CC1E:121670:9F1606:BF66A6:6880C121
[BIg tensor] fix acc error for forward addmm by hxzd5568 · Pull Request #73436 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[BIg tensor] fix acc error for forward addmm #73436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lshpku
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
Pcard-67164
本pr修复了addmm前向精度不充足的错误
修复前，paddle遇到float16类型的addmm时，调用的是cublasHgemm 函数，也就是计算精度为float16,在大tensor中会出现精度问题。
而修复后使用cublasGemmEx函数，计算精度为float32, 不容易产生累加误差。
修复后性能下降1%左右；修复后与torch调用核函数一致
小tensor(m,n,k: 5, 800, 5) 降速仅 1% 。
大tensor(m,n,k: 5, 80000000, 5) 降速仅 2% 。
修复后前向kernel：1,912,515 ns
void cutlass::Kernel<cutlass_75_wmma_tensorop_ ** s ** 161616gemm_f16_16x16_128x1_nn_align1>
（图中展示torch 和修复后 paddle addmm前向调用函数名称相同，被nsys合并统计）
修复前前向kernel：1,874,851 ns
void cutlass::Kernel<cutlass_75_wmma_tensorop_** h **161616gemm_16x16_128x1_nn_align1>
torch 前向kernel：1,899,108 ns
void cutlass::Kernel<cutlass_75_wmma_tensorop_** s **161616gemm_f16_16x16_128x1_nn_align1>
（图中展示torch 和修复前 paddle addmm前向调用函数不同）