| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 10:52:24 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=383.610315,conversation_content-fragment;desc="conversation_content fragment";dur=790.873043,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=350.579893,nginx;desc="NGINX";dur=0.765317,glb;desc="GLB";dur=101.070324
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=llNi58eJBy5NzWvny%2F%2FL28VU45V4ILd7wvptdilrb5uWnHE6Enym%2BnGz4VVr%2FDncEOkNO%2F99ylp4l%2FX1dCALCECBITBpe4HyC03B%2FamRgIzvMYciPK0vcUz0rgHf4elww0s%2FpRX0yFEnlXuoJIJdVI8LkYETUYhZg9rOzT8tCiPWHklPLhhDFLflNOLpDv4fwHhH77Jte2SxaqK7HQzctSQkhF2kJhe%2FI2%2B1q75lx1LvqTFx3plxgiL3J3H%2FK%2BW%2BK7u%2BziVE%2BRDuUiN3qGHQig%3D%3D--3fkNJU8SiNmgPNyb--dKVPWOaPM8ddOJWXT6XNrA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1957074502.1753267943; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:52:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:52:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B3D2:261FF2:9B1807:BB1E87:6880BEE7
[PHI] Handle dynamic dim in pixel (un)shuffle infermeta by SigureMo · Pull Request #73339 · PaddlePaddle/Paddle · GitHub
SigureMo
changed the title
[PHI][CINN] Handle dynamic dim in pixel (un)shuffle infermeta
[PHI] Handle dynamic dim in pixel (un)shuffle infermeta
Jun 15, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PHI] Handle dynamic dim in pixel (un)shuffle infermeta #73339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:phi/handle-dynamic-dim-in-pixel-shuffle-infermeta
Jun 15, 2025
Merged
[PHI] Handle dynamic dim in pixel (un)shuffle infermeta #73339
SigureMo
merged 1 commit into
PaddlePaddle:develop
from
cattidea:phi/handle-dynamic-dim-in-pixel-shuffle-infermeta
Jun 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for propagating dynamic dimensions (-1) in the PixelShuffle and PixelUnshuffle infermeta and gradient infermeta functions to avoid invalid negative sizes.
- Introduces an inline helper
HandleDynamicDimto return-1for dynamic dims or compute a static result otherwise - Updates all channel‐first/channel‐last dimension computations in
PixelShuffleInferMeta,PixelShuffleGradInferMeta,PixelUnshuffleInferMeta, andPixelUnshuffleGradInferMetato use this helper
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| paddle/phi/infermeta/unary.cc | Added HandleDynamicDim and applied it to all pixel shuffle dimension adjustments |
| paddle/phi/infermeta/backward.cc | Added HandleDynamicDim and applied it to pixel unshuffle gradient dimensions |
Comments suppressed due to low confidence (1)
paddle/phi/infermeta/unary.cc:3230
- There are no tests validating the new dynamic-dimension behavior. Add unit tests for
PixelShuffleandPixelUnshuffleinfermeta to ensure-1dims are correctly propagated.
return maybe_dynamic_dim == -1 ? -1 : static_result;
| @@ -3225,6 +3225,11 @@ void PartialSendInferMeta(const MetaTensor& x, int peer, int num, int id) { | |||
| "The id (%d) for partial_send op must >=0 and <num (%d)", id, num)); | |||
| } | |||
|
|
|||
| inline int64_t HandleDynamicDim(int64_t maybe_dynamic_dim, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HandleDynamicDim helper is defined in two separate files, leading to code duplication. Consider moving this function into a shared utility header (e.g., infermeta_utils.h) and including it where needed.
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
gouzil
approved these changes
Jun 15, 2025
SigureMo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
#73287 添加了动态 dim 不允许为非
-1的负数的检查，可能是因为精准测试，导致跑得并不完全，#73337 暴露了pixel_shuffleinfermeta 出现-2的情况，因此本 PR 将PixelShuffle、PixelUnShuffle及其反向都进行了动态 dim 的处理，避免出现其他负数的情况