| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 10:52:36 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=271.695457,conversation_content-fragment;desc="conversation_content fragment";dur=532.487552,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=332.877562,nginx;desc="NGINX";dur=0.666178,glb;desc="GLB";dur=101.403118
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=UQQ5LFdCCQHMMfuAeG8fM5QHBEAWzi8HXPvgQyTDPnwsog86bu6PPRRWkdvEjC8ByBuEoOF7LWMVXJ2vMNRZHZH%2B4iP0LD4JBuNC5fzlXNwXirPB5mkLk%2FWBeAdfkHbqYshQa%2FoK0EhVAvJ17Kpc5eE3CuD05S9Jb%2BfLjJPSwDsWuaE7aDrfsEAhE51poiwekA69%2F9M3VAgCDWbFfT%2FD7v6YQ7lsxmi%2BRzs7dZeAUhPBQleX8BoVYdRWV5kCqWte3XuT2Z9l6eK%2Fb5QA5VtHHQ%3D%3D--9ZY%2FqQ81oSGzxuuP--ZLQOREsXfGBOwIP027qyNw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.893026238.1753267955; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:52:35 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 10:52:35 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 92FE:167F3A:9AF92E:BAFFE4:6880BEF3
[CodeStyle][SIM117] Combine multiple `with` statements (part1) by SigureMo · Pull Request #73338 · PaddlePaddle/Paddle · GitHub
[CodeStyle][SIM117] Combine multiple
SigureMo
requested review from
Copilot
and removed request for
zrr1999 and
gouzil
June 14, 2025 20:13
SigureMo
changed the title
[CodeStyle][SIM117] Combine multiple with statements (part1)
[CodeStyle][SIM117] Combine multiple Jun 15, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[CodeStyle][SIM117] Combine multiple with statements (part1)
#73338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,628
−3,371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigureMo
requested review from
Copilot
and removed request for
zrr1999 and
gouzil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the code by combining multiple nested with statements into a single, multi-context manager block in order to reduce unnecessary indentation and improve readability. The changes span several test files and utility modules to streamline context management, enhancing overall code maintainability.
Reviewed Changes
Copilot reviewed 108 out of 108 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/deprecated/legacy_test/test_entry_attr2_deprecated.py | Combined nested with statements into a single block to reduce indentation. |
| test/deprecated/legacy_test/test_dataset_dataloader_deprecated.py | Unified multiple with statements for clearer context management. |
| test/deprecated/legacy_test/test_conv3d_layer_deprecated.py | Reduced nesting by combining with statements for unique name guards and program guards. |
| test/deprecated/legacy_test/test_conv2d_transpose_layer_deprecated.py | Simplified context management by merging with statements in both base_layer and functional methods. |
| test/deprecated/legacy_test/test_conv2d_layer_deprecated.py | Combined nested with statements for improved readability in base_layer and functional methods. |
| test/deprecated/ir/inference/test_trt_matmul_quant_dequant_deprecated.py | Refactored with statements to use multi-context blocks for program guards and unique name guards. |
| test/deprecated/ir/inference/test_trt_fc_fuse_quant_dequant_pass_deprecated.py | Merged with statements to streamline guard usage for both main and test programs. |
| test/deprecated/ir/inference/test_trt_conv_quant_dequant_pass_deprecated.py | Combined with statements to reduce nesting in the setup of program and unique name guards. |
| test/deprecated/auto_parallel/auto_parallel_pass_test_base_deprecated.py | Unified with statements for program guard, scope guard, and unique name guard in a single block. |
| test/amp/test_amp_o2_embedding_model.py | Merged with statements for unique name and program guards in the AMP model setup. |
| test/amp/test_amp_master_weight.py | Combined with statements to simplify context management in the AMP master weight test. |
| test/amp/test_amp_list.py | Refactored with statements to group IR guards and program guards, reducing nested block structure. |
| test/amp/test_amp_decorate.py | Unified with statements for IR guard and program guard in the AMP decorate test. |
| test/amp/test_amp_api.py | Combined with statements to streamline guard usage across different AMP API tests. |
| python/paddle/tensorrt/util.py | Refactored with statements by grouping IR guard and program guard for better clarity. |
| python/paddle/nn/layer/rnn.py | Merged with statements to combine program_guard and no_grad contexts, improving readability. |
| python/paddle/jit/dy2static/utils.py | Combined nested with statements in composed_guard for a cleaner implementation. |
| python/paddle/distributed/fleet/recompute/recompute.py | Combined nested with statements to handle AMP auto_cast and RNG state management more succinctly. |
| python/paddle/distributed/auto_parallel/static/tuner/rule_based_tuner.py | Streamlined context management by merging with statements for program_guard and name generator switching. |
| python/paddle/cinn/compiler/compute_code_generator.py | Consolidated with statements for variable table and loop context management, reducing unnecessary nesting. |
|
skip-reason: codestyle only |
gouzil
approved these changes
Jun 15, 2025
SigureMo
changed the title
with statements (part1)
This was referenced Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
User Experience
PR Types
Improvements
Description
准备引入 Ruff SIM1171，将连续多个
with语句合并为一个，减少代码缩进层级，此为 part1Tracker
withstatements (part1) #73338Footnotes
https://docs.astral.sh/ruff/rules/multiple-with-statements/ ↩