| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 06:20:50 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=255.599273,conversation_content-fragment;desc="conversation_content fragment";dur=1161.005943,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=299.445687,nginx;desc="NGINX";dur=1.217997,glb;desc="GLB";dur=100.575008
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=TzNlX8PMGilGLrUcbXDMUwpWCoaNh1GCsz5mav0Cj3OLAuxgBh6C2r79TZhjzFprjIHK%2BQL75cOm7cUxyyC2arszOD7PNVZtsIJcRohXgiyt1gU9S8rZrWHjnCrsUfrqGwno9WdDdifcvzOz5yJHdqrGol5X9vTdUkDUNMyJKjYwBw7KSLt%2BBzkClBmwKNRmQ4GUGSWZNysGBCGIJyVS9GOfjwBhGxRYLEp98CrZ%2BdnAlxz2WWEL3cg3WFgmCVtcriM3ktTaiI1c8GP4QEJUWw%3D%3D--%2FghYoBNr%2BeRaIW95--AlFYtnXcoBuECaeZpED3Zg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.297162977.1753510849; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 06:20:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 06:20:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CAEE:3240E6:23AA24:3225AF:688473C1
【Operator Mechanism】add fused_stack_transpose_quant api by ggggxm · Pull Request #73228 · PaddlePaddle/Paddle · GitHub
lshpku
changed the title
【Operator Mechanism 】add fused_stack_transpose_quant api
【Operator Mechanism】add fused_stack_transpose_quant api
Jun 10, 2025
ggggxm
force-pushed
the
stack_tranpose_quant
branch
from
June 11, 2025 06:52
ggggxm
force-pushed
the
stack_tranpose_quant
branch
from
June 13, 2025 06:08
还有为啥要把一个tensor resize成自己的dims？这样会产生什么变化吗
ggggxm
force-pushed
the
stack_tranpose_quant
branch
from
June 13, 2025 12:14
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
【Operator Mechanism】add fused_stack_transpose_quant api #73228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhangbo9674
merged 5 commits into
PaddlePaddle:develop
from
ggggxm:stack_tranpose_quant
Jun 14, 2025
Merged
【Operator Mechanism】add fused_stack_transpose_quant api #73228
zhangbo9674
merged 5 commits into
PaddlePaddle:develop
from
ggggxm:stack_tranpose_quant
Jun 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lshpku
changed the title
ggggxm
force-pushed
the
stack_tranpose_quant
branch
from
b8eefa1 to
daff73d
Compare
zhangbo9674
reviewed
Jun 11, 2025
paddle/phi/ops/yaml/ops.yaml
Outdated
| @@ -2382,6 +2382,24 @@ | |||
| backward: fused_softmax_mask_upper_triangle_grad | |||
| interfaces : paddle::dialect::InferSymbolicShapeInterface | |||
|
|
|||
| - op : fused_stack_quant | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有一个专门存放融合算子的：paddle/phi/ops/yaml/fused_ops.yaml
| #include <iostream> | ||
| #include <limits> | ||
|
|
||
| // #include "paddle/extension.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete unused code
| } \ | ||
| } | ||
|
|
||
| // 对二维坐标进行swizzle变换，提供相对offset,避免bank conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
中文注释清理一下
ggggxm
force-pushed
the
stack_tranpose_quant
branch
from
daff73d to
149c8c1
Compare
zyfncg
reviewed
Jun 13, 2025
paddle/phi/infermeta/multiary.cc
Outdated
| @@ -6245,6 +6245,108 @@ void FullWithTensorInferMeta(const IntArray& shape, | |||
| out->set_dtype(dtype); | |||
| } | |||
|
|
|||
| std::tuple<int64_t, int64_t, int64_t> FusedStackQuantCommonCheck( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
放到fusion.h/.cc中
paddle/phi/infermeta/multiary.h
Outdated
Comment on lines
553
to
554
| std::tuple<int64_t, int64_t, int64_t> FusedStackQuantCommonCheck( | ||
| const std::vector<const MetaTensor*>& x); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
非InferMeta函数不用把声明加到.h
| @@ -0,0 +1,84 @@ | |||
| # Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2023 -> 2025
python/paddle/nn/functional/fp8.py
Outdated
|
|
||
|
|
||
| """ | ||
| if in_dynamic_mode(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dynamic or pir mode
python/paddle/nn/functional/fp8.py
Outdated
| else: | ||
| return _C_ops.fused_stack_quant(x) | ||
|
|
||
| else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else分支去掉
lshpku
reviewed
Jun 13, 2025
Comment on lines
79
to
84
| dev_ctx.template Alloc<phi::dtype::float8_e4m3fn>(out); | ||
| dev_ctx.template Alloc<float>(scale); | ||
| auto out_dims = out->dims(); | ||
| out->Resize(out_dims); | ||
| auto scale_dims = scale->dims(); | ||
| scale->Resize(scale_dims); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一般是先resize才alloc：
Paddle/paddle/fluid/framework/operator.h
Lines 594 to 597 in c999558
| phi::DenseTensor tmp; | |
| tmp.Resize(dim); | |
| dev_ctx.template Alloc<T>(&tmp); | |
| return tmp; |
还有为啥要把一个tensor resize成自己的dims？这样会产生什么变化吗
ggggxm
force-pushed
the
stack_tranpose_quant
branch
from
f6798e5 to
4ddde16
Compare
zyfncg
previously approved these changes
Jun 13, 2025
zhangbo9674
previously approved these changes
Jun 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 06ca104.
lshpku
approved these changes
Jun 14, 2025
zhangbo9674
approved these changes
Jun 14, 2025
zyfncg
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Operator Mechanism
PR Types
New features
Description
新增fused_stack_transpose_quant和fused_stack_quant支持