| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 24 Jul 2025 21:53:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=315.674129,conversation_content-fragment;desc="conversation_content fragment";dur=560.221509,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=298.819446,nginx;desc="NGINX";dur=0.983117,glb;desc="GLB";dur=100.328073
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=akqg8Wk1TvK9QA2CWUhdUDEPOHdxULC%2B5MU9RW1MEY79aFUvUOMYE5DUd%2BuCLhugLVkiJgcvGcev6T%2BL%2BIcu0Aqhq4iJJZsvFHpRBu6ohGRGpijOFk8Prc%2FxzG0jYDIMphFbftc9ycWuE42V5OVB22GDTIO5epfryNe2VQgl15g4RRWKjmSevc%2BOwnWDACTZUOo30sJgRUFQM5ojI1EXBN9YVTXN3hI7vQtEDi5R850UjahOG9%2FM9pmKih2oLIW6FdqGn0BABCIPevHxJ1ARGQ%3D%3D--qyvzInNbL5c1nFaB--ykfp%2BLZeFMVT6Gmc28BaKw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.198704800.1753394019; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 21:53:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 21:53:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 85DE:1FBC86:B0C0E:F6ECF:6882AB63
[PHI]Fix paddle.incubate.softmax_mask_fuse_upper_triangle for big tensor by DanielSun11 · Pull Request #73121 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PHI]Fix paddle.incubate.softmax_mask_fuse_upper_triangle for big tensor #73121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wanghuancoder
merged 3 commits into
PaddlePaddle:develop
from
DanielSun11:fix_softmax_mask_fuse_upper_triangle
Jun 12, 2025
Merged
[PHI]Fix paddle.incubate.softmax_mask_fuse_upper_triangle for big tensor #73121
wanghuancoder
merged 3 commits into
PaddlePaddle:develop
from
DanielSun11:fix_softmax_mask_fuse_upper_triangle
Jun 12, 2025
+92
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
lshpku
approved these changes
Jun 12, 2025
wanghuancoder
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shanjiang7
pushed a commit
to shanjiang7/Paddle
that referenced
this pull request
Jun 12, 2025
…sor (PaddlePaddle#73121) * fix forward and backward kernel * fix data type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
修复paddle.incubate.softmax_mask_fuse_upper_triangle 遇到大tensor时报CUDA Error 9（非法配置）的问题。
问题出现的原因：
FusedSoftmaxMaskFuseUpperTriangleKernel和FusedSoftmaxMaskFuseUpperTriangleGradKernel中
Paddle/paddle/phi/kernels/fusion/gpu/fused_softmax_mask_upper_triangle_kernel.cu
Lines 191 to 193 in 4b03294
(attn_mul_batch + batches_per_block) / batches_per_block超过了GridDim.y的最大值，从而引起CUDA Error 9。修复方案
计算所需要的所有的block的数量然后采用一维划分的方法，然后在cuda kernel中每个block根据blockId以及原来划分方式的GridDim信息重新映射成原来的二维划分。
CUDA Kernel中引入了一次整数除法和整数取模的操作。
性能对比
Nisght system测出的 FusedSoftmaxMaskFuseUpperTriangleKernel耗时对比：
Nisght system测出的 FusedSoftmaxMaskFuseUpperTriangleGradKernel耗时对比：
测试：
PaddleAPITest的回测结果：
pcard-67164